[Feature Request] Toggle clickthrough #3
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
khyretos/3dco-plus#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Every time I start the app, I have to toggle this manually, reposition both windwos (controller and history), then toggle clickthrough option in main menu again. It would be nice if we can toggle this quicker without using the main menu on the fly. I have three ideas (but don't mind any other idea too):
Hey i took your sugestion and im implementing the following:
hopefully you agree with the changes
Wow, are you joking? How could I not agree? :D Thank you for taking your time and looking into it this quickly.
As for the position remembering, it's actually Wayland that does not remember or does not support it. Its a long standing issue with Wayland. I think KDE on Wayland does some internal tricks to remember it, but I don't know. That's not a priority to me anyway. I will test it when its out and report any issues then.
Ok as it stands:
i have changed some things:
i hope this satisfies your requirements. v1.3.0 is building as we speak. the release became bigger due to another feature request i got through discord so i decided to do a minor bump.
As for the window positioning, I can do that manually. That is not an issue.
Can you verify if you user is part of the "Input" group or try to use the keyboard or mouse model. if you see that the models dont react to anything then your user is probably not part of the group and if you want it to work (as in the program listen to your keyboard/mouse events) then you will need to run the following command
sudo usermod -a -G input $USERand then restart the pc or session but this command does implicate a security risk.here is the awnser from the brave browser AI:
Maybe you can specify the device but i cant work around this since it is a security thing in linux.
you can try it for testing purposes and then reverting it. but this is a limitation/risk i cannot work around for now. sorry.
Hmm, those commands are for Xorg / X11 I think (or XWayland, which is not Wayland), so not for my system. As I thought, on Wayland there is this global hotkey problem I think. But I have a different idea.
Maybe a toggle could be added to the Taskbar Icon.
Thats a great idea! Ill add them in the next patch.
But i did have to add these in my system as well and im using cachyos/hyprland. So maybe its worth the try or maybe look at the wayland alternative to this.
Also does the keyboard and mouse model work for you?
OK, so good news, it works. I was hesitant to try this
sudo usermod -a -G input $USERcommand. But after you mentioned that you had to use it in CachyOS, I had to, because I'm on EndeavourOS and these use the same base Archlinux.And indeed, now toggle shortcut works, keyboard and mouse work too (it didn't before). Input History and the model, mouse, keyboard, gamepad, shortcuts. No complains about the functionality at this point! Thank you so much for this.
The only thing is, I'm not entirely sure about the security aspect using the "input" group. In the end, having the toggle in the taskbar could be a "satisfying" workaround of this problem. I guess this is a solved issue now? The very least this information (also that udev is recommended over input group) should be noted in the README, for Wayland users.
Happy to know it works, and yes i will note it in the readme because it is something users should be made aware of.
dont close the issue, when i add the taskbar functionality you can close it. :) thank you for the feedback!
So the tray icon has the possibility now to toggle click through and drag to move, unfortunately for my system i need to open the tray icon 2 times if i want to disable both checkboxes because after confirming an action it inmedeatly closes and i to open it again to toggle the other one. I tried making it so it stays open, but this is something i was not able to fix. maybe its because of my system maybe its a linux thing. but at least it works. so hopefully v1.3.1 works for you.
It works... but there are issues.
Tray Icon
It works, the menu entries will toggle the settings. That it closes after an entry selection is normal. My only complain would be, that the menu entries are too nested. And there is a little issue, but that should be discussed on a dedicated tracker.
Click-Through and Shortcut
I'm not sure if this was the behavior before, but when Click-Through is disabled, I can no longer move my window. The issue is following... See I use the Meta or Windows key (known as Left GUI here) to hold to move any window on my system. And that is also set as the key to toggle here.
Global system shortcut key to move window: Left GUI
My suggestion is, regardless of any current mode, as long as the shortcut is hold, Click-Through should switch temporarily and stay ON. If someone doesn't want that, then shortcut can be disabled.
So right now v1.3.2 should behave exactly as you described i just need you to test it as i cannot reproduce it due to the nature of hyprland.
the idea is that holding the shortcut for "drag to move" triggers the "click through" to ON (it does not show it visuall but it does so internally). since this is a very niche feature it is only documented so please verify this for me and hopefully we can close the issue :D
It works like described as before. Little bit inconsistent, because I cannot move window when click through is ON. But it works overall, once a setup is found. There are ways to switch to on and off.