khyretos/kk-engine
1
0
Fork 0
Code Issues 1 Pull requests 16 Projects Releases Packages Wiki Activity Actions 1

Creatures and pathfinding in Lua games: nav.* and ai.* (ENG-F70) #121

Closed
khyretos wants to merge 3 commits from khyretos/claude/lua-nav into main AGit
pull from: khyretos/claude/lua-nav
merge into: khyretos:main
Conversation 10 Commits 3 Files changed 11 +516 -8
khyretos commented 2026-10-25 05:08:10 +01:00
Owner
Copy link

Requested by Kees · project thread

Stacked on #119 (moving-door navmesh): merge that first; this PR then shows only its own two commits.

What (ENG-F70: pathfinding and creatures for Lua games)

  • nav.* for scripts: nav.build{radius, height, climb, slope, cell, tile, dynamic} makes a navmesh from the level's collision (every static body: script boxes, scenes, terrain), through the new RigidWorld::staticTriangles. Then path(from, to) → corners and partial, walkable, nearest, move (slides along walls), random, and obstacle{pos, size, yaw} / {pos, radius, height} → id, remove(id). A script's obstacles and navmesh go when it unloads (256 obstacles per script).
  • ai.* creatures for scripts: ScriptModule keeps one ai::AiWorld whose agents are the script's models. ai.add(model, "dog") gives it a mind; every frame it walks the navmesh, stands on the ground (static raycast), sees only what isn't behind a wall, turns where it goes, and plays the clip that ai.anims(inst, {idle=, walk=, run=, attack=, ...}) names for what it does (run falls back to walk, anything else to idle; attacks play once). ai.actor(id, pos [, species, velocity]) places someone with no model, such as the player (ids from 1,000,000). New models.position(inst) → pos, yaw. models.remove and script unload take the mind away too.
  • Fix in AiWorld: Arrived fired every frame between reaching a goTo/fetch goal and the next think tick. It now fires once.
  • Docs: SCRIPTING.md "Finding the way" and "Creatures" (plus nav, ai and models.position in the table), AI.md "Lua", GAPS F70.

Tests

  • New RigidWorld.StaticTrianglesAreTheLevelsCollision; AiWorld.OrdersWinAndReportArrival now asserts exactly one Arrived per order.
  • Full kke_tests: 1250 passed, no warnings at -Wall -Wextra.
  • In starter_game with a test script: nav.build() made 28 polygons in 7.8 ms from the template level. Three UAL mannequins given ai.add(inst, "dog") and ai.goTo walked 12 m across the level on the navmesh playing Walk, faced their way, spotted each other and the ai.actor, fired Arrived once each, then held their spot playing Idle.

🤖 Generated with Claude Code

https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7

<!-- claude-projects-attribution: {"github_login":"Khyretos"} --> _Requested by **Kees** · [project thread](https://claude.ai/code/project/chan_01Ds4PKvSLCNCCKr5TJxrV2A?thread=cmsg_01Ds4PKvSLCNCCKr5TJxrV2ABb2WaYyLkc7eUMNFVK1p2Z)_ **Stacked on #119** (moving-door navmesh): merge that first; this PR then shows only its own two commits. ## What (ENG-F70: pathfinding and creatures for Lua games) - `nav.*` for scripts: `nav.build{radius, height, climb, slope, cell, tile, dynamic}` makes a navmesh from the level's collision (every static body: script boxes, scenes, terrain), through the new `RigidWorld::staticTriangles`. Then `path(from, to)` → corners and `partial`, `walkable`, `nearest`, `move` (slides along walls), `random`, and `obstacle{pos, size, yaw}` / `{pos, radius, height}` → id, `remove(id)`. A script's obstacles and navmesh go when it unloads (256 obstacles per script). - `ai.*` creatures for scripts: `ScriptModule` keeps one `ai::AiWorld` whose agents are the script's models. `ai.add(model, "dog")` gives it a mind; every frame it walks the navmesh, stands on the ground (static raycast), sees only what isn't behind a wall, turns where it goes, and plays the clip that `ai.anims(inst, {idle=, walk=, run=, attack=, ...})` names for what it does (run falls back to walk, anything else to idle; attacks play once). `ai.actor(id, pos [, species, velocity])` places someone with no model, such as the player (ids from 1,000,000). New `models.position(inst)` → pos, yaw. `models.remove` and script unload take the mind away too. - Fix in `AiWorld`: `Arrived` fired every frame between reaching a goTo/fetch goal and the next think tick. It now fires once. - Docs: SCRIPTING.md "Finding the way" and "Creatures" (plus `nav`, `ai` and `models.position` in the table), AI.md "Lua", GAPS F70. ## Tests - New `RigidWorld.StaticTrianglesAreTheLevelsCollision`; `AiWorld.OrdersWinAndReportArrival` now asserts exactly one `Arrived` per order. - Full `kke_tests`: 1250 passed, no warnings at `-Wall -Wextra`. - In starter_game with a test script: `nav.build()` made 28 polygons in 7.8 ms from the template level. Three UAL mannequins given `ai.add(inst, "dog")` and `ai.goTo` walked 12 m across the level on the navmesh playing Walk, faced their way, spotted each other and the `ai.actor`, fired `Arrived` once each, then held their spot playing Idle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7
Navmesh obstacles: tiled navmeshes that doors and crates change (ENG-F70)
All checks were successful
review / pr-agent PR-Agent reviewed this commit
CI / dependencies (pull_request) Successful in 4s
Details
CI / std-includes (pull_request) Successful in 12s
Details
CI / shipping-build (pull_request) Successful in 12m52s
Details
Benchmarks / benchmarks (pull_request) Successful in 3m0s
Details
Docs site / site (pull_request) Successful in 9s
Details
lint / megalinter (pull_request) Successful in 1m0s
Details
CI / build-test-and-coverage (pull_request) Successful in 1h10m56s
Details
CI / release-build (pull_request) Successful in 43m59s
Details
Windows (native) / build (pull_request) Successful in 10m29s
Details
CI / android (pull_request) Successful in 30m5s
Details
Windows (native) / test (pull_request) Successful in 7m17s
Details
Windows (native) / publish (pull_request) Has been skipped
Details
kk / all-checks All 13 checks passed
7d23a53286
 
NavMesh::buildDynamic builds the level as square tiles in a DetourTileCache.
addBoxObstacle (turned by the engine's yaw) and addCylinderObstacle cut holes,
removeObstacle fills them, and update() rebuilds only the touched tiles, a
few per call. Queries are unchanged. revision() counts the changes, and
AiWorld finds an agent's path again when it moves on, so agents go round a
door that shuts.

Tests: a dynamic mesh answers like a built one, a crate in a doorway blocks
the path until it is removed, paths bend round a pillar, a turned box blocks
its own diagonal and not the other, and a dog takes the far door when the
near one shuts. docs/AI.md; GAPS F70 updated.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7
Lua games had no navigation. nav.build makes a navmesh (dynamic by
default) from every static body's shape, via the new
RigidWorld::staticTriangles. nav.path, walkable, nearest, move and random
query it. nav.obstacle (a box by its middle, or a post) and nav.remove
change it, and ScriptModule updates it every frame. A script's obstacles go
when it unloads, and the mesh goes with the script that built it.
ScriptModule::navMesh() hands it to C++.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7
Creatures in Lua games: ai.* on script models, walking the navmesh (ENG-F70)
Some checks failed
kk / all-checks Waiting for: Benchmarks / benchmarks (pull_request), CI / android (pull_request), CI / build-test-and-coverage (pull_request), CI / dependencies (pull_request), CI / release-build (pull_request), CI / shipping-build (pull_request), CI / std-includes
review / pr-agent PR-Agent reviewed this commit
Benchmarks / benchmarks (pull_request) Has been cancelled
Details
CI / dependencies (pull_request) Has been cancelled
Details
CI / std-includes (pull_request) Has been cancelled
Details
CI / shipping-build (pull_request) Has been cancelled
Details
CI / build-test-and-coverage (pull_request) Has been cancelled
Details
CI / release-build (pull_request) Has been cancelled
Details
CI / android (pull_request) Has been cancelled
Details
Docs site / site (pull_request) Has been cancelled
Details
lint / megalinter (pull_request) Has been cancelled
Details
Windows (native) / build (pull_request) Has been cancelled
Details
Windows (native) / test (pull_request) Has been cancelled
Details
Windows (native) / publish (pull_request) Has been cancelled
Details
701ba8db97
 
ScriptModule keeps one ai::AiWorld whose agents are the script's models.
ai.add gives a model a mind; each frame it walks the nav.build navmesh,
stands on the level's collision, turns where it goes and plays the clip
ai.anims named for what it does (run falls back to walk, the rest to
idle). ai.actor places someone without a model (the player).
models.position reads where a model is. Removing a model or unloading
the script takes its mind away.

AiWorld fired Arrived every frame between reaching a goTo or fetch goal
and the next think; it now fires once (test asserts it).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7
kompas-review scheduled this pull request to auto merge when all checks succeed 2026-10-25 05:08:22 +01:00
kompas-review commented 2026-10-25 05:09:14 +01:00
Collaborator
Copy link

Title

Creatures and pathfinding in Lua games: nav.* and ai.* (ENG-F70)

User description

Requested by Kees · project thread

Stacked on #119 (moving-door navmesh): merge that first; this PR then shows only its own two commits.

What (ENG-F70: pathfinding and creatures for Lua games)

  • nav.* for scripts: nav.build{radius, height, climb, slope, cell, tile, dynamic} makes a navmesh from the level's collision (every static body: script boxes, scenes, terrain), through the new RigidWorld::staticTriangles. Then path(from, to) → corners and partial, walkable, nearest, move (slides along walls), random, and obstacle{pos, size, yaw} / {pos, radius, height} → id, remove(id). A script's obstacles and navmesh go when it unloads (256 obstacles per script).
  • ai.* creatures for scripts: ScriptModule keeps one ai::AiWorld whose agents are the script's models. ai.add(model, "dog") gives it a mind; every frame it walks the navmesh, stands on the ground (static raycast), sees only what isn't behind a wall, turns where it goes, and plays the clip that ai.anims(inst, {idle=, walk=, run=, attack=, ...}) names for what it does (run falls back to walk, anything else to idle; attacks play once). ai.actor(id, pos [, species, velocity]) places someone with no model, such as the player (ids from 1,000,000). New models.position(inst) → pos, yaw. models.remove and script unload take the mind away too.
  • Fix in AiWorld: Arrived fired every frame between reaching a goTo/fetch goal and the next think tick. It now fires once.
  • Docs: SCRIPTING.md "Finding the way" and "Creatures" (plus nav, ai and models.position in the table), AI.md "Lua", GAPS F70.

Tests

  • New RigidWorld.StaticTrianglesAreTheLevelsCollision; AiWorld.OrdersWinAndReportArrival now asserts exactly one Arrived per order.
  • Full kke_tests: 1250 passed, no warnings at -Wall -Wextra.
  • In starter_game with a test script: nav.build() made 28 polygons in 7.8 ms from the template level. Three UAL mannequins given ai.add(inst, "dog") and ai.goTo walked 12 m across the level on the navmesh playing Walk, faced their way, spotted each other and the ai.actor, fired Arrived once each, then held their spot playing Idle.

🤖 Generated with Claude Code

https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7

PR Type

Enhancement

Description

  • Adds dynamic tiled navmeshes with obstacles for Lua games

  • Implements nav.* pathfinding and ai.* creature system

  • Enables agents to re-path around moving crates and doors

Diagram Walkthrough

flowchart TD
  Level["Level Collision"] --> Triangles["RigidWorld::staticTriangles"]
  Triangles --> Build["NavMesh::buildDynamic"]
  Build --> Tiles["Tiled Mesh"]
  Tiles --> Obstacles["addBoxObstacle / addCylinderObstacle"]
  Obstacles --> Update["NavMesh::update"]
  Update --> Agents["AiWorld Agents"]
  Agents --> Move["Walk & Re-path"]

File Walkthrough
Relevant files
Enhancement
4 files
RigidWorld.cpp
Extracts static level collision as triangles for navmesh building
 +32/-0   
NavMesh.cpp
Implements dynamic tiled navmeshes with obstacle support 
+296/-15
ScriptBindings.cpp
Exposes nav.* pathfinding and ai.* creature APIs to Lua   
+322/-1 
ScriptModule.cpp
Integrates navmesh and creatures into script lifecycle     
+4/-0     
Bug fix
1 files
AiWorld.cpp
Fixes Arrived event firing once per order instead of every frame
 +11/-3   
Tests
2 files
test_ai.cpp
Adds tests for dynamic navmeshes, obstacles, and agent behavior
 +144/-0 
test_rigid_world.cpp
Tests staticTriangles extraction from rigid bodies             
+35/-0   
Documentation
7 files
RigidWorld.h
Declares staticTriangles method for extracting level geometry
 +5/-0     
AiWorld.h
Adds pathRevision field to track navmesh updates                 
+1/-0     
NavMesh.h
Declares dynamic build methods and obstacle management     
+35/-1   
ScriptModule.h
Adds navmesh and AiWorld accessors plus creature clip storage
 +20/-0   
AI.md
Documents dynamic navmeshes and Lua creature integration 
+30/-2   
GAPS.md
Updates ENG-F70 status to reflect completed pathfinding work
 +1/-1     
SCRIPTING.md
Documents nav.* and ai.* functions for game scripts           
+69/-1   
## Title Creatures and pathfinding in Lua games: nav.* and ai.* (ENG-F70) ___ ### **User description** <!-- claude-projects-attribution: {"github_login":"Khyretos"} --> _Requested by **Kees** · [project thread](https://claude.ai/code/project/chan_01Ds4PKvSLCNCCKr5TJxrV2A?thread=cmsg_01Ds4PKvSLCNCCKr5TJxrV2ABb2WaYyLkc7eUMNFVK1p2Z)_ **Stacked on #119** (moving-door navmesh): merge that first; this PR then shows only its own two commits. ## What (ENG-F70: pathfinding and creatures for Lua games) - `nav.*` for scripts: `nav.build{radius, height, climb, slope, cell, tile, dynamic}` makes a navmesh from the level's collision (every static body: script boxes, scenes, terrain), through the new `RigidWorld::staticTriangles`. Then `path(from, to)` → corners and `partial`, `walkable`, `nearest`, `move` (slides along walls), `random`, and `obstacle{pos, size, yaw}` / `{pos, radius, height}` → id, `remove(id)`. A script's obstacles and navmesh go when it unloads (256 obstacles per script). - `ai.*` creatures for scripts: `ScriptModule` keeps one `ai::AiWorld` whose agents are the script's models. `ai.add(model, "dog")` gives it a mind; every frame it walks the navmesh, stands on the ground (static raycast), sees only what isn't behind a wall, turns where it goes, and plays the clip that `ai.anims(inst, {idle=, walk=, run=, attack=, ...})` names for what it does (run falls back to walk, anything else to idle; attacks play once). `ai.actor(id, pos [, species, velocity])` places someone with no model, such as the player (ids from 1,000,000). New `models.position(inst)` → pos, yaw. `models.remove` and script unload take the mind away too. - Fix in `AiWorld`: `Arrived` fired every frame between reaching a goTo/fetch goal and the next think tick. It now fires once. - Docs: SCRIPTING.md "Finding the way" and "Creatures" (plus `nav`, `ai` and `models.position` in the table), AI.md "Lua", GAPS F70. ## Tests - New `RigidWorld.StaticTrianglesAreTheLevelsCollision`; `AiWorld.OrdersWinAndReportArrival` now asserts exactly one `Arrived` per order. - Full `kke_tests`: 1250 passed, no warnings at `-Wall -Wextra`. - In starter_game with a test script: `nav.build()` made 28 polygons in 7.8 ms from the template level. Three UAL mannequins given `ai.add(inst, "dog")` and `ai.goTo` walked 12 m across the level on the navmesh playing Walk, faced their way, spotted each other and the `ai.actor`, fired `Arrived` once each, then held their spot playing Idle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7 ___ ### **PR Type** Enhancement ___ ### **Description** - Adds dynamic tiled navmeshes with obstacles for Lua games - Implements `nav.*` pathfinding and `ai.*` creature system - Enables agents to re-path around moving crates and doors ___ ### Diagram Walkthrough ```mermaid flowchart TD Level["Level Collision"] --> Triangles["RigidWorld::staticTriangles"] Triangles --> Build["NavMesh::buildDynamic"] Build --> Tiles["Tiled Mesh"] Tiles --> Obstacles["addBoxObstacle / addCylinderObstacle"] Obstacles --> Update["NavMesh::update"] Update --> Agents["AiWorld Agents"] Agents --> Move["Walk & Re-path"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>4 files</summary><table> <tr> <td><strong>RigidWorld.cpp</strong><dd><code>Extracts static level collision as triangles for navmesh building</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/RigidWorld.cpp">+32/-0</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>NavMesh.cpp</strong><dd><code>Implements dynamic tiled navmeshes with obstacle support</code>&nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/ai/NavMesh.cpp">+296/-15</a></td> </tr> <tr> <td><strong>ScriptBindings.cpp</strong><dd><code>Exposes nav.* pathfinding and ai.* creature APIs to Lua</code>&nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/modules/ScriptBindings.cpp">+322/-1</a>&nbsp; </td> </tr> <tr> <td><strong>ScriptModule.cpp</strong><dd><code>Integrates navmesh and creatures into script lifecycle</code>&nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/modules/ScriptModule.cpp">+4/-0</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Bug fix</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>AiWorld.cpp</strong><dd><code>Fixes Arrived event firing once per order instead of every frame</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/ai/AiWorld.cpp">+11/-3</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>test_ai.cpp</strong><dd><code>Adds tests for dynamic navmeshes, obstacles, and agent behavior</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/tests/test_ai.cpp">+144/-0</a>&nbsp; </td> </tr> <tr> <td><strong>test_rigid_world.cpp</strong><dd><code>Tests staticTriangles extraction from rigid bodies</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/tests/test_rigid_world.cpp">+35/-0</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Documentation</strong></td><td><details><summary>7 files</summary><table> <tr> <td><strong>RigidWorld.h</strong><dd><code>Declares staticTriangles method for extracting level geometry</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/include/kke/RigidWorld.h">+5/-0</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>AiWorld.h</strong><dd><code>Adds pathRevision field to track navmesh updates</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/include/kke/ai/AiWorld.h">+1/-0</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>NavMesh.h</strong><dd><code>Declares dynamic build methods and obstacle management</code>&nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/include/kke/ai/NavMesh.h">+35/-1</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>ScriptModule.h</strong><dd><code>Adds navmesh and AiWorld accessors plus creature clip storage</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/include/kke/modules/ScriptModule.h">+20/-0</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>AI.md</strong><dd><code>Documents dynamic navmeshes and Lua creature integration</code>&nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/docs/AI.md">+30/-2</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>GAPS.md</strong><dd><code>Updates ENG-F70 status to reflect completed pathfinding work</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/docs/GAPS.md">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>SCRIPTING.md</strong><dd><code>Documents nav.* and ai.* functions for game scripts</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/docs/SCRIPTING.md">+69/-1</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___
kompas-review commented 2026-10-25 05:09:53 +01:00
Collaborator
Copy link

PR Reviewer Guide 🔍

(Review updated until commit cf0885bd9a)

📋 Focus areas: 🔴 3 open · ✅ 2 handled. Every push re-checks them; a handled area moves to Resolved findings at the bottom.

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Potential Logic Error in Creature Cleanup

In releaseScript, the code calls forgetCreature(m.id) and then models->remove(m.id). However, forgetCreature removes the agent from m_ai and clips from m_creatureClips, but it does not remove the model instance from m_models. The subsequent loop that erases models from m_models might be affected if the logic for tracking which models belong to the script relies on m_models being consistent. Specifically, if a model is removed from m_models before forgetCreature is called (which happens in the loop immediately after), there could be a mismatch. The current order seems intentional (cleanup AI first, then remove model), but it's worth verifying that forgetCreature doesn't depend on the model still being in m_models to function correctly. If forgetCreature only uses m.id and m.source (which are available in the loop), this should be fine. However, the comment "Its obstacles; the navmesh with the script that built it" suggests that the navmesh cleanup is also part of this process. Ensure that the order of operations (AI cleanup -> Model removal -> Navmesh cleanup) is correct and doesn't cause issues if a model is referenced by multiple scripts or if the navmesh cleanup depends on the model's state.

 
if (mine(m.source)) {
    forgetCreature(m.id);
    models->remove(m.id);
}
Missing Validation for Actor ID in ai.actor

The ai.actor function checks if the ID is less than 1,000,000 or greater than 0x7fffffff, but it does not check if the ID is already in use by another actor or model. This could lead to overwriting existing actors or models, causing unexpected behavior. Additionally, the function does not validate that the ID is positive, which could lead to undefined behavior if a negative ID is passed.

 
} else {
Potential Memory Leak in Dynamic NavMesh

In buildDynamic, if dtAllocTileCache() or dtAllocNavMesh() fails, the allocated memory is not freed before returning an error. This could lead to a memory leak if the allocation fails multiple times. The code should ensure that any allocated resources are properly cleaned up in the error paths.

 
m->cache = dtAllocTileCache();
if (!m->cache || dtStatusFailed(m->cache->init(&tc, &m->cacheAlloc, &m->compressor, &m->process))) return fail("Detour could not start the tile cache");

dtNavMeshParams np{};
rcVcopy(np.orig, bmin);
np.tileWidth = tileWorld;
np.tileHeight = tileWorld;
np.maxTiles = int(1u << tileBits);
np.maxPolys = int(1u << (22 - tileBits));
m->mesh = dtAllocNavMesh();
if (!m->mesh || dtStatusFailed(m->mesh->init(&np))) return fail("Detour could not start the tiled mesh");
m->query = dtAllocNavMeshQuery();
if (!m->query || dtStatusFailed(m->query->init(m->mesh, kMaxNodes))) return fail("Detour could not start a query");
✅ Resolved findings

engine/src/ai/AiWorld.cpp:1046-1049

Potential Logic Error in Interact Order Handling

Similar to the previous issue, in AiWorld::act, the condition if (a.order.kind != Order::Kind::Interact) is used to check if an agent has arrived at its interaction target. The logic here assumes that if the order is not Interact, the agent should brake and go idle. However, this could lead to incorrect behavior if an agent arrives while under a different order type (e.g., MoveTo). The code structure suggests that MoveTo and Interact are handled separately, but the early exit for non-Interact orders could interfere with the intended flow if an agent arrives while under a different order type. This needs verification against the expected behavior where agents should transition to idle only after completing their specific task.

engine/src/ai/AiWorld.cpp:984-987

Potential Logic Error in Order Handling

In AiWorld::act, the condition if (a.order.kind != Order::Kind::MoveTo) is used to detect when an agent has arrived and should stop animating. However, this logic assumes that only MoveTo orders are active when the agent is not at its goal. If other order types (like Interact) are also considered "arrived" states, they might incorrectly trigger the idle animation logic before the specific handling for those orders occurs. The code structure suggests that MoveTo and Interact are handled separately, but the early exit for non-MoveTo orders could interfere with the intended flow if an agent arrives while under a different order type. This needs verification against the expected behavior where agents should transition to idle only after completing their specific task.

## PR Reviewer Guide 🔍 <!-- pr-agent:review:full --> #### (Review updated until commit https://git.kreative-kompas.com/khyretos/kk-engine/commit/cf0885bd9a12099fc8b6c15a8212695c311946dd) 📋 **Focus areas:** 🔴 3 open · ✅ 2 handled. Every push re-checks them; a handled area moves to *Resolved findings* at the bottom. <table> <tr><td>⏱️&nbsp;<strong>Estimated effort to review</strong>: 3 🔵🔵🔵⚪⚪</td></tr> <tr><td>🧪&nbsp;<strong>PR contains tests</strong></td></tr> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/modules/ScriptBindings.cpp#L1157-L1160'><strong>Potential Logic Error in Creature Cleanup</strong></a> In `releaseScript`, the code calls `forgetCreature(m.id)` and then `models->remove(m.id)`. However, `forgetCreature` removes the agent from `m_ai` and clips from `m_creatureClips`, but it does not remove the model instance from `m_models`. The subsequent loop that erases models from `m_models` might be affected if the logic for tracking which models belong to the script relies on `m_models` being consistent. Specifically, if a model is removed from `m_models` before `forgetCreature` is called (which happens in the loop immediately after), there could be a mismatch. The current order seems intentional (cleanup AI first, then remove model), but it's worth verifying that `forgetCreature` doesn't depend on the model still being in `m_models` to function correctly. If `forgetCreature` only uses `m.id` and `m.source` (which are available in the loop), this should be fine. However, the comment "Its obstacles; the navmesh with the script that built it" suggests that the navmesh cleanup is also part of this process. Ensure that the order of operations (AI cleanup -> Model removal -> Navmesh cleanup) is correct and doesn't cause issues if a model is referenced by multiple scripts or if the navmesh cleanup depends on the model's state. </summary> ```c++ if (mine(m.source)) { forgetCreature(m.id); models->remove(m.id); } ``` </details> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/ai/AiWorld.cpp#L1062-L1062'><strong>Missing Validation for Actor ID in ai.actor</strong></a> The `ai.actor` function checks if the ID is less than 1,000,000 or greater than 0x7fffffff, but it does not check if the ID is already in use by another actor or model. This could lead to overwriting existing actors or models, causing unexpected behavior. Additionally, the function does not validate that the ID is positive, which could lead to undefined behavior if a negative ID is passed. </summary> ```c++ } else { ``` </details> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/121/head/engine/src/ai/NavMesh.cpp#L296-L308'><strong>Potential Memory Leak in Dynamic NavMesh</strong></a> In `buildDynamic`, if `dtAllocTileCache()` or `dtAllocNavMesh()` fails, the allocated memory is not freed before returning an error. This could lead to a memory leak if the allocation fails multiple times. The code should ensure that any allocated resources are properly cleaned up in the error paths. </summary> ```c++ m->cache = dtAllocTileCache(); if (!m->cache || dtStatusFailed(m->cache->init(&tc, &m->cacheAlloc, &m->compressor, &m->process))) return fail("Detour could not start the tile cache"); dtNavMeshParams np{}; rcVcopy(np.orig, bmin); np.tileWidth = tileWorld; np.tileHeight = tileWorld; np.maxTiles = int(1u << tileBits); np.maxPolys = int(1u << (22 - tileBits)); m->mesh = dtAllocNavMesh(); if (!m->mesh || dtStatusFailed(m->mesh->init(&np))) return fail("Detour could not start the tiled mesh"); m->query = dtAllocNavMeshQuery(); if (!m->query || dtStatusFailed(m->query->init(m->mesh, kMaxNodes))) return fail("Detour could not start a query"); ``` </details> </td></tr> </table> <details> <summary>✅ Resolved findings</summary> ### engine/src/ai/AiWorld.cpp:1046-1049 **Potential Logic Error in Interact Order Handling** Similar to the previous issue, in `AiWorld::act`, the condition `if (a.order.kind != Order::Kind::Interact)` is used to check if an agent has arrived at its interaction target. The logic here assumes that if the order is not `Interact`, the agent should brake and go idle. However, this could lead to incorrect behavior if an agent arrives while under a different order type (e.g., `MoveTo`). The code structure suggests that `MoveTo` and `Interact` are handled separately, but the early exit for non-`Interact` orders could interfere with the intended flow if an agent arrives while under a different order type. This needs verification against the expected behavior where agents should transition to idle only after completing their specific task. ### engine/src/ai/AiWorld.cpp:984-987 **Potential Logic Error in Order Handling** In `AiWorld::act`, the condition `if (a.order.kind != Order::Kind::MoveTo)` is used to detect when an agent has arrived and should stop animating. However, this logic assumes that only `MoveTo` orders are active when the agent is not at its goal. If other order types (like `Interact`) are also considered "arrived" states, they might incorrectly trigger the idle animation logic before the specific handling for those orders occurs. The code structure suggests that `MoveTo` and `Interact` are handled separately, but the early exit for non-`MoveTo` orders could interfere with the intended flow if an agent arrives while under a different order type. This needs verification against the expected behavior where agents should transition to idle only after completing their specific task. </details> <!-- pr-agent-review-state:v1 {"findings":[{"body":"**Potential Memory Leak in Dynamic NavMesh**\n\nIn `buildDynamic`, if `dtAllocTileCache()` or `dtAllocNavMesh()` fails, the allocated memory is not freed before returning an error. This could lead to a memory leak if the allocation fails multiple times. The code should ensure that any allocated resources are properly cleaned up in the error paths.","finding_id":"45844452aeda","first_seen":"2026-10-25T12:08:42.926668Z","last_seen":"2026-10-25T12:08:42.926668Z","last_seen_head_sha":"cf0885bd9a12099fc8b6c15a8212695c311946dd","line_end":308,"line_start":296,"path":"engine/src/ai/NavMesh.cpp","state":"ACTIVE"},{"body":"**Potential Logic Error in Order Handling**\n\nIn `AiWorld::act`, the condition `if (a.order.kind != Order::Kind::MoveTo)` is used to detect when an agent has arrived and should stop animating. However, this logic assumes that only `MoveTo` orders are active when the agent is not at its goal. If other order types (like `Interact`) are also considered \"arrived\" states, they might incorrectly trigger the idle animation logic before the specific handling for those orders occurs. The code structure suggests that `MoveTo` and `Interact` are handled separately, but the early exit for non-`MoveTo` orders could interfere with the intended flow if an agent arrives while under a different order type. This needs verification against the expected behavior where agents should transition to idle only after completing their specific task.","finding_id":"465919448c11","first_seen":"2026-10-25T04:09:53.552226Z","last_seen":"2026-10-25T04:09:53.552226Z","last_seen_head_sha":"701ba8db9711ba06dc63009d0924b3c700d65da0","line_end":987,"line_start":984,"path":"engine/src/ai/AiWorld.cpp","resolution_run_id":"https://git.kreative-kompas.com/khyretos/kk-engine/commit/cf0885bd9a12099fc8b6c15a8212695c311946dd","resolved_at":"2026-10-25T12:08:42.926668Z","resolved_head_sha":"cf0885bd9a12099fc8b6c15a8212695c311946dd","state":"RESOLVED"},{"body":"**Potential Logic Error in Interact Order Handling**\n\nSimilar to the previous issue, in `AiWorld::act`, the condition `if (a.order.kind != Order::Kind::Interact)` is used to check if an agent has arrived at its interaction target. The logic here assumes that if the order is not `Interact`, the agent should brake and go idle. However, this could lead to incorrect behavior if an agent arrives while under a different order type (e.g., `MoveTo`). The code structure suggests that `MoveTo` and `Interact` are handled separately, but the early exit for non-`Interact` orders could interfere with the intended flow if an agent arrives while under a different order type. This needs verification against the expected behavior where agents should transition to idle only after completing their specific task.","finding_id":"85cd3a2c6d5d","first_seen":"2026-10-25T04:09:53.552226Z","last_seen":"2026-10-25T04:09:53.552226Z","last_seen_head_sha":"701ba8db9711ba06dc63009d0924b3c700d65da0","line_end":1049,"line_start":1046,"path":"engine/src/ai/AiWorld.cpp","resolution_run_id":"https://git.kreative-kompas.com/khyretos/kk-engine/commit/cf0885bd9a12099fc8b6c15a8212695c311946dd","resolved_at":"2026-10-25T12:08:42.926668Z","resolved_head_sha":"cf0885bd9a12099fc8b6c15a8212695c311946dd","state":"RESOLVED"},{"body":"**Missing Validation for Actor ID in ai.actor**\n\nThe `ai.actor` function checks if the ID is less than 1,000,000 or greater than 0x7fffffff, but it does not check if the ID is already in use by another actor or model. This could lead to overwriting existing actors or models, causing unexpected behavior. Additionally, the function does not validate that the ID is positive, which could lead to undefined behavior if a negative ID is passed.","finding_id":"b36ce4f5195e","first_seen":"2026-10-25T12:08:42.926668Z","last_seen":"2026-10-25T12:08:42.926668Z","last_seen_head_sha":"cf0885bd9a12099fc8b6c15a8212695c311946dd","line_end":1062,"line_start":1062,"path":"engine/src/ai/AiWorld.cpp","state":"ACTIVE"},{"body":"**Potential Logic Error in Creature Cleanup**\n\nIn `releaseScript`, the code calls `forgetCreature(m.id)` and then `models->remove(m.id)`. However, `forgetCreature` removes the agent from `m_ai` and clips from `m_creatureClips`, but it does not remove the model instance from `m_models`. The subsequent loop that erases models from `m_models` might be affected if the logic for tracking which models belong to the script relies on `m_models` being consistent. Specifically, if a model is removed from `m_models` before `forgetCreature` is called (which happens in the loop immediately after), there could be a mismatch. The current order seems intentional (cleanup AI first, then remove model), but it's worth verifying that `forgetCreature` doesn't depend on the model still being in `m_models` to function correctly. If `forgetCreature` only uses `m.id` and `m.source` (which are available in the loop), this should be fine. However, the comment \"Its obstacles; the navmesh with the script that built it\" suggests that the navmesh cleanup is also part of this process. Ensure that the order of operations (AI cleanup -> Model removal -> Navmesh cleanup) is correct and doesn't cause issues if a model is referenced by multiple scripts or if the navmesh cleanup depends on the model's state.","finding_id":"f113d981d558","first_seen":"2026-10-25T12:08:42.926668Z","last_seen":"2026-10-25T12:08:42.926668Z","last_seen_head_sha":"cf0885bd9a12099fc8b6c15a8212695c311946dd","line_end":1160,"line_start":1157,"path":"engine/src/modules/ScriptBindings.cpp","state":"ACTIVE"}],"last_run":{"complete":true,"excluded_files":[],"head_sha":"cf0885bd9a12099fc8b6c15a8212695c311946dd","kind":"full","run_id":"https://git.kreative-kompas.com/khyretos/kk-engine/commit/cf0885bd9a12099fc8b6c15a8212695c311946dd"},"schema_version":1} -->
kompas-review commented 2026-10-25 05:10:33 +01:00
Collaborator
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

## PR Code Suggestions ✨ <!-- pr-agent:improve:no-suggestions --> No code suggestions found for the PR.
CI check: add a missing standard include
All checks were successful
review / pr-agent PR-Agent reviewed this commit
CI / dependencies (pull_request) Successful in 4s
Details
CI / std-includes (pull_request) Successful in 10s
Details
CI / shipping-build (pull_request) Successful in 12m5s
Details
Benchmarks / benchmarks (pull_request) Successful in 4m10s
Details
CI / release-build (pull_request) Successful in 8m56s
Details
Docs site / site (pull_request) Successful in 10s
Details
lint / megalinter (pull_request) Successful in 1m20s
Details
Windows (native) / build (pull_request) Successful in 11m27s
Details
Windows (native) / test (pull_request) Successful in 8m4s
Details
CI / android (pull_request) Successful in 35m20s
Details
CI / build-test-and-coverage (pull_request) Successful in 1h9m57s
Details
Windows (native) / publish (pull_request) Has been skipped
Details
kk / all-checks All 13 checks passed
cf0885bd9a
 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rkS6wq7fV9fWdiLwxyyc7
kompas-review commented 2026-10-25 14:40:13 +01:00
Collaborator
Copy link

This PR needs main merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.

<!-- kk-automerge:conflict --> This PR needs `main` merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.
kompas-review commented 2026-10-25 14:45:22 +01:00
Collaborator
Copy link

This PR needs main merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.

<!-- kk-automerge:conflict --> This PR needs `main` merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.
forgejo-actions commented 2026-10-25 15:34:27 +01:00
Copy link

🧹 Lint report · ❌ 37 problems in 6 checks · 🧹 3 formatting checks to tidy

Nothing here blocks the merge (report only).

Check Errors Warnings Files
❌ MARKDOWN · markdownlint 23 0 250
❌ CPP · cppcheck 9 0 895
❌ YAML · yamllint 2 0 56
❌ BASH · shellcheck 1 0 11
❌ DOCKERFILE · hadolint 1 0 9
❌ REPOSITORY · trivy 1 0 –
MARKDOWN · markdownlint: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/markdown_markdownlint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
docs/ANDROID.md:87 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:128 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:136 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:149 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:163 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:186 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:21 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: " Kreative Kompas Engine (KKE)"]
docs/HISTORY.md:520 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:727 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:734 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:2031 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:2090 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/MODDING.md:13 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/NETWORKING.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PLATFORMS.md:48 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PROCEDURAL_ANIMATION.md:36 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PROCEDURAL_ANIMATION.md:284 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
games/racing/README.md:34 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
games/racing/README.md:76:91 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
games/racing/README.md:77:89 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
games/racing/README.md:78:32 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
…
CPP · cppcheck: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/cpp_cppcheck/
-----------------------------------------------
✅ [SUCCESS] benchmarks/kke_bench/main.cpp
✅ [SUCCESS] benchmarks/kke_benchmark/main.cpp
✅ [SUCCESS] engine/include/engine/Buffer.h
✅ [SUCCESS] engine/include/engine/Mesh.h
✅ [SUCCESS] engine/include/engine/Pipeline.h
✅ [SUCCESS] engine/include/engine/Renderer.h
✅ [SUCCESS] engine/include/engine/SwapChain.h
✅ [SUCCESS] engine/include/engine/VulkanCheck.h
✅ [SUCCESS] engine/include/engine/VulkanDevice.h
✅ [SUCCESS] engine/include/engine/Window.h
✅ [SUCCESS] engine/include/kke/AnimRig.h
✅ [SUCCESS] engine/include/kke/Animator.h
✅ [SUCCESS] engine/include/kke/Application.h
✅ [SUCCESS] engine/include/kke/AssetCatalog.h
✅ [SUCCESS] engine/include/kke/AudioMixer.h
✅ [SUCCESS] engine/include/kke/AutoRig.h
✅ [SUCCESS] engine/include/kke/BenchRecorder.h
✅ [SUCCESS] engine/include/kke/BenchmarkReport.h
✅ [SUCCESS] engine/include/kke/Bloom.h
✅ [SUCCESS] engine/include/kke/BodyShape.h
✅ [SUCCESS] engine/include/kke/BreakGraph.h
✅ [SUCCESS] engine/include/kke/Breakables.h
✅ [SUCCESS] engine/include/kke/Buffer.h
…
YAML · yamllint: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/yaml_yamllint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
games/goblin_horde/data/heroes.yml
  53:11     error    too many spaces after colon  (colons)
  63:11     error    too many spaces after colon  (colons)
BASH · shellcheck: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/bash_shellcheck/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
In tools/packaging/package.sh line 130:
	done < <(find "$stage" "$stage/benchmark" -maxdepth 1 -type f \( -name "*$exe" -o -name '*.dll' \) $([ -z "$exe" ] && echo "-perm -u+x") -print0)
                                                                                                           ^-- SC2046 (warning): Quote this to prevent word splitting.
For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
DOCKERFILE · hadolint: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/dockerfile_hadolint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
docker/android.Dockerfile:19 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:38 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.
docker/appimage.Dockerfile:51 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:57 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:63 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:63 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:73 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:73 DL3003 warning: Use WORKDIR to switch to a directory
docker/ci.Dockerfile:42 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/ci.Dockerfile:56 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/server/Dockerfile:22 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/vm.Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
docker/vm.Dockerfile:29 DL3003 warning: Use WORKDIR to switch to a directory
docker/vm.Dockerfile:29 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
website/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
REPOSITORY · trivy: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/repository_trivy/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
2026-10-25T14:33:18Z	INFO	[vulndb] Need to update DB
2026-10-25T14:33:18Z	INFO	[vulndb] Downloading vulnerability DB...
2026-10-25T14:33:18Z	INFO	[vulndb] Downloading artifact...	repo="mirror.gcr.io/aquasec/trivy-db:2"
19.26 MiB / 129.84 MiB [-------->___________________________________________________] 14.83% ? p/s ?32.55 MiB / 129.84 MiB [--------------->____________________________________________] 25.07% ? p/s ?40.20 MiB / 129.84 MiB [------------------>_________________________________________] 30.96% ? p/s ?48.34 MiB / 129.84 MiB [----------------->_____________________________] 37.23% 48.40 MiB p/s ETA 1s56.69 MiB / 129.84 MiB [-------------------->__________________________] 43.66% 48.40 MiB p/s ETA 1s65.08 MiB / 129.84 MiB [----------------------->_______________________] 50.12% 48.40 MiB p/s ETA 1s72.75 MiB / 129.84 MiB [-------------------------->____________________] 56.03% 47.90 MiB p/s ETA 1s80.84 MiB / 129.84 MiB [----------------------------->_________________] 62.26% 47.90 MiB p/s ETA 1s89.21 MiB / 129.84 MiB [-------------------------------->______________] 68.71% 47.90 MiB p/s ETA 0s97.12 MiB / 129.84 MiB [----------------------------------->___________] 74.80% 47.43 MiB p/s ETA 0s104.92 MiB / 129.84 MiB [------------------------------------->________] 80.81% 47.43 MiB p/s ETA 0s112.34 MiB / 129.84 MiB [--------------------------------------->______] 86.53% 47.43 MiB p/s ETA 0s119.96 MiB / 129.84 MiB [------------------------------------------>___] 92.39% 46.83 MiB p/s ETA 0s127.60 MiB / 129.84 MiB [--------------------------------------------->] 98.28% 46.83 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 46.83 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 44.87 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 44.87 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 44.87 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 41.97 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 41.97 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 41.97 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 39.27 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 39.27 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 39.27 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 36.73 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 36.73 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 36.73 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 34.36 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 34.36 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 34.36 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 32.15 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 32.15 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 32.15 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 30.07 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 30.07 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 30.07 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 28.13 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 28.13 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-----------------------------------------------] 100.00% 17.28 MiB p/s 7.7s2026-10-25T14:33:26Z	INFO	[vulndb] Artifact successfully downloaded	repo="mirror.gcr.io/aquasec/trivy-db:2"
2026-10-25T14:33:26Z	INFO	[vuln] Vulnerability scanning is enabled
2026-10-25T14:33:26Z	INFO	[misconfig] Misconfiguration scanning is enabled
2026-10-25T14:33:26Z	INFO	[checks-client] Need to update the checks bundle
2026-10-25T14:33:26Z	INFO	[checks-client] Downloading the checks bundle...
234.57 KiB / 234.57 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2026-10-25T14:33:27Z	WARN	[rego] Module will be skipped as current version of Trivy is older than minimum trivy version required - please update Trivy to use this module	file_path="root/.cache/trivy/policy/content/policies/cloud/policies/aws/cloudfront/enable_logging.rego" minimum_trivy_version="0.72.0"
2026-10-25T14:33:27Z	ERROR	[dockerfile scanner] Failed to parse file	file_path="docker/server/Dockerfile.dockerignore" err="parse dockerfile instruction: parse instruction \".git\": unknown instruction: .git"
2026-10-25T14:33:27Z	INFO	Number of language-specific files	num=0
2026-10-25T14:33:27Z	INFO	Detected config files	num=9
Report Summary
┌──────────────────────────────┬────────────┬─────────────────┬───────────────────┐
│            Target            │    Type    │ Vulnerabilities │ Misconfigurations │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ benchmarks/docker/Dockerfile │ dockerfile │        -        │         2         │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ docker/android.Dockerfile    │ dockerfile │        -        │         2         │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ docker/appimage.Dockerfile   │ dockerfile │        -        │         5         │
…

🧹 Formatting only (layout, no behaviour; the nightly lint-fix job applies these as a PR): YAML · prettier (56 files checked), BASH · shfmt (11 files checked), JSON · prettier (145 files checked)

✅ Clean: actionlint, git_diff, gitleaks, grype, jsonlint, secretlint, stylelint, trufflehog, xmllint

MegaLinter on soucouyant · full logs in the Actions run · comment /improve for AI fix suggestions

<!-- kk-lint --> ## 🧹 Lint report · ❌ 37 problems in 6 checks · 🧹 3 formatting checks to tidy Nothing here blocks the merge (report only). | | Check | Errors | Warnings | Files | |---|---|---:|---:|---:| | ❌ | MARKDOWN · markdownlint | 23 | 0 | 250 | | ❌ | CPP · cppcheck | 9 | 0 | 895 | | ❌ | YAML · yamllint | 2 | 0 | 56 | | ❌ | BASH · shellcheck | 1 | 0 | 11 | | ❌ | DOCKERFILE · hadolint | 1 | 0 | 9 | | ❌ | REPOSITORY · trivy | 1 | 0 | – | <details><summary>MARKDOWN · markdownlint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/markdown_markdownlint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: docs/ANDROID.md:87 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:128 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:136 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:149 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:163 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:186 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:21 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: " Kreative Kompas Engine (KKE)"] docs/HISTORY.md:520 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:727 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:734 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:2031 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:2090 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/MODDING.md:13 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/NETWORKING.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PLATFORMS.md:48 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PROCEDURAL_ANIMATION.md:36 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PROCEDURAL_ANIMATION.md:284 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] games/racing/README.md:34 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] games/racing/README.md:76:91 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] games/racing/README.md:77:89 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] games/racing/README.md:78:32 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] … ``` </details> <details><summary>CPP · cppcheck: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/cpp_cppcheck/ ----------------------------------------------- ✅ [SUCCESS] benchmarks/kke_bench/main.cpp ✅ [SUCCESS] benchmarks/kke_benchmark/main.cpp ✅ [SUCCESS] engine/include/engine/Buffer.h ✅ [SUCCESS] engine/include/engine/Mesh.h ✅ [SUCCESS] engine/include/engine/Pipeline.h ✅ [SUCCESS] engine/include/engine/Renderer.h ✅ [SUCCESS] engine/include/engine/SwapChain.h ✅ [SUCCESS] engine/include/engine/VulkanCheck.h ✅ [SUCCESS] engine/include/engine/VulkanDevice.h ✅ [SUCCESS] engine/include/engine/Window.h ✅ [SUCCESS] engine/include/kke/AnimRig.h ✅ [SUCCESS] engine/include/kke/Animator.h ✅ [SUCCESS] engine/include/kke/Application.h ✅ [SUCCESS] engine/include/kke/AssetCatalog.h ✅ [SUCCESS] engine/include/kke/AudioMixer.h ✅ [SUCCESS] engine/include/kke/AutoRig.h ✅ [SUCCESS] engine/include/kke/BenchRecorder.h ✅ [SUCCESS] engine/include/kke/BenchmarkReport.h ✅ [SUCCESS] engine/include/kke/Bloom.h ✅ [SUCCESS] engine/include/kke/BodyShape.h ✅ [SUCCESS] engine/include/kke/BreakGraph.h ✅ [SUCCESS] engine/include/kke/Breakables.h ✅ [SUCCESS] engine/include/kke/Buffer.h … ``` </details> <details><summary>YAML · yamllint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/yaml_yamllint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: games/goblin_horde/data/heroes.yml 53:11 error too many spaces after colon (colons) 63:11 error too many spaces after colon (colons) ``` </details> <details><summary>BASH · shellcheck: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/bash_shellcheck/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: In tools/packaging/package.sh line 130: done < <(find "$stage" "$stage/benchmark" -maxdepth 1 -type f \( -name "*$exe" -o -name '*.dll' \) $([ -z "$exe" ] && echo "-perm -u+x") -print0) ^-- SC2046 (warning): Quote this to prevent word splitting. For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... ``` </details> <details><summary>DOCKERFILE · hadolint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/dockerfile_hadolint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: docker/android.Dockerfile:19 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:38 SC2016 info: Expressions don't expand in single quotes, use double quotes for that. docker/appimage.Dockerfile:51 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:57 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:63 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:63 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:73 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:73 DL3003 warning: Use WORKDIR to switch to a directory docker/ci.Dockerfile:42 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/ci.Dockerfile:56 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/server/Dockerfile:22 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/vm.Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting. docker/vm.Dockerfile:29 DL3003 warning: Use WORKDIR to switch to a directory docker/vm.Dockerfile:29 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check website/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check ``` </details> <details><summary>REPOSITORY · trivy: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/repository_trivy/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: 2026-10-25T14:33:18Z INFO [vulndb] Need to update DB 2026-10-25T14:33:18Z INFO [vulndb] Downloading vulnerability DB... 2026-10-25T14:33:18Z INFO [vulndb] Downloading artifact... repo="mirror.gcr.io/aquasec/trivy-db:2" 19.26 MiB / 129.84 MiB [-------->___________________________________________________] 14.83% ? p/s ?32.55 MiB / 129.84 MiB [--------------->____________________________________________] 25.07% ? p/s ?40.20 MiB / 129.84 MiB [------------------>_________________________________________] 30.96% ? p/s ?48.34 MiB / 129.84 MiB [----------------->_____________________________] 37.23% 48.40 MiB p/s ETA 1s56.69 MiB / 129.84 MiB [-------------------->__________________________] 43.66% 48.40 MiB p/s ETA 1s65.08 MiB / 129.84 MiB [----------------------->_______________________] 50.12% 48.40 MiB p/s ETA 1s72.75 MiB / 129.84 MiB [-------------------------->____________________] 56.03% 47.90 MiB p/s ETA 1s80.84 MiB / 129.84 MiB [----------------------------->_________________] 62.26% 47.90 MiB p/s ETA 1s89.21 MiB / 129.84 MiB [-------------------------------->______________] 68.71% 47.90 MiB p/s ETA 0s97.12 MiB / 129.84 MiB [----------------------------------->___________] 74.80% 47.43 MiB p/s ETA 0s104.92 MiB / 129.84 MiB [------------------------------------->________] 80.81% 47.43 MiB p/s ETA 0s112.34 MiB / 129.84 MiB [--------------------------------------->______] 86.53% 47.43 MiB p/s ETA 0s119.96 MiB / 129.84 MiB [------------------------------------------>___] 92.39% 46.83 MiB p/s ETA 0s127.60 MiB / 129.84 MiB [--------------------------------------------->] 98.28% 46.83 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 46.83 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 44.87 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 44.87 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 44.87 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 41.97 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 41.97 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 41.97 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 39.27 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 39.27 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 39.27 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 36.73 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 36.73 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 36.73 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 34.36 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 34.36 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 34.36 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 32.15 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 32.15 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 32.15 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 30.07 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 30.07 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 30.07 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 28.13 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-------------------------------------------->] 100.00% 28.13 MiB p/s ETA 0s129.84 MiB / 129.84 MiB [-----------------------------------------------] 100.00% 17.28 MiB p/s 7.7s2026-10-25T14:33:26Z INFO [vulndb] Artifact successfully downloaded repo="mirror.gcr.io/aquasec/trivy-db:2" 2026-10-25T14:33:26Z INFO [vuln] Vulnerability scanning is enabled 2026-10-25T14:33:26Z INFO [misconfig] Misconfiguration scanning is enabled 2026-10-25T14:33:26Z INFO [checks-client] Need to update the checks bundle 2026-10-25T14:33:26Z INFO [checks-client] Downloading the checks bundle... 234.57 KiB / 234.57 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2026-10-25T14:33:27Z WARN [rego] Module will be skipped as current version of Trivy is older than minimum trivy version required - please update Trivy to use this module file_path="root/.cache/trivy/policy/content/policies/cloud/policies/aws/cloudfront/enable_logging.rego" minimum_trivy_version="0.72.0" 2026-10-25T14:33:27Z ERROR [dockerfile scanner] Failed to parse file file_path="docker/server/Dockerfile.dockerignore" err="parse dockerfile instruction: parse instruction \".git\": unknown instruction: .git" 2026-10-25T14:33:27Z INFO Number of language-specific files num=0 2026-10-25T14:33:27Z INFO Detected config files num=9 Report Summary ┌──────────────────────────────┬────────────┬─────────────────┬───────────────────┐ │ Target │ Type │ Vulnerabilities │ Misconfigurations │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ benchmarks/docker/Dockerfile │ dockerfile │ - │ 2 │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ docker/android.Dockerfile │ dockerfile │ - │ 2 │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ docker/appimage.Dockerfile │ dockerfile │ - │ 5 │ … ``` </details> 🧹 Formatting only (layout, no behaviour; the nightly lint-fix job applies these as a PR): YAML · prettier (56 files checked), BASH · shfmt (11 files checked), JSON · prettier (145 files checked) ✅ Clean: actionlint, git_diff, gitleaks, grype, jsonlint, secretlint, stylelint, trufflehog, xmllint <sub>MegaLinter on soucouyant · full logs in the Actions run · comment <code>/improve</code> for AI fix suggestions</sub>
kompas-review commented 2026-10-25 15:47:24 +01:00
Collaborator
Copy link

This PR needs main merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.

<!-- kk-automerge:conflict --> This PR needs `main` merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.
kompas-review commented 2026-10-25 16:32:16 +01:00
Collaborator
Copy link

This PR needs main merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.

<!-- kk-automerge:conflict --> This PR needs `main` merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.
kompas-review commented 2026-10-25 17:40:00 +01:00
Collaborator
Copy link

This PR needs main merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.

<!-- kk-automerge:conflict --> This PR needs `main` merged in (a plain merge works), but it was pushed to refs/for/main, so only its author can update it: merge main in and push it again.
kompas-review commented 2026-10-25 19:01:50 +01:00
Collaborator
Copy link

This PR conflicts with main and the bot could not merge it in by itself:

  • engine/include/kke/modules/ScriptModule.h
  • engine/src/modules/ScriptModule.cpp

Reply union to keep both sides in every file (CI then checks the result), or merge main in by hand.

<!-- kk-automerge:conflict --> This PR conflicts with `main` and the bot could not merge it in by itself: - `engine/include/kke/modules/ScriptModule.h` - `engine/src/modules/ScriptModule.cpp` Reply `union` to keep both sides in every file (CI then checks the result), or merge main in by hand.
khyretos closed this pull request 2026-10-25 20:34:32 +01:00
All checks were successful
review / pr-agent PR-Agent reviewed this commit
Required
CI / dependencies (pull_request) Successful in 4s
Required
Details
CI / std-includes (pull_request) Successful in 10s
Required
Details
CI / shipping-build (pull_request) Successful in 12m5s
Required
Details
Benchmarks / benchmarks (pull_request) Successful in 4m10s
Required
Details
CI / release-build (pull_request) Successful in 8m56s
Required
Details
Docs site / site (pull_request) Successful in 10s
Required
Details
lint / megalinter (pull_request) Successful in 1m20s
Required
Details
Windows (native) / build (pull_request) Successful in 11m27s
Required
Details
Windows (native) / test (pull_request) Successful in 8m4s
Required
Details
CI / android (pull_request) Successful in 35m20s
Required
Details
CI / build-test-and-coverage (pull_request) Successful in 1h9m57s
Required
Details
Windows (native) / publish (pull_request) Has been skipped
Details
kk / all-checks All 13 checks passed
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
deps
Renovate: patch/minor/digest update

  
deps-major
Renovate: major or 0.x minor update

  
hold
kompas-review waits until Kees replies merge

  
security
Renovate: fixes a known vulnerability

No labels
deps
deps-major
hold
security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
khyretos/kk-engine!121
No description provided.