ACTIVITY-NOTE, ZOOM-NOTE: refused/allowed entries are cards like steps; zoom size note can be turned off #321

Merged
khyretos merged 3 commits from khyretos/activity-notes into main 2026-10-29 11:00:14 +01:00
Owner

Follow-up to #320.

  • Activity: a refused, allowed or removed grant entry was a bare line. It is now a card like a step and a fact: header (pin icon, what, state chip), dark body (the detail, for a refusal the tool that was refused), footer (kind chip, computer, time). It is a note, so it does not fold; long paths wrap. Demo data has a refused entry.
  • Zoom: the note with the size ("Text size 115%") stays 1.8 s instead of 1.2 s. New setting in Settings > Appearance: "Show the size in a short note when zooming" (on by default, remembered on the device).
  • Tests: activity.spec (refused card), ux-round2.spec (setting). 38 playwright pass in the four specs touched, tsc clean.

Desktop drop: the dragDropEnabled: false setting from #320 is compiled into the app, so it only takes effect in a rebuilt desktop app (desktop/install-linux.sh).

Follow-up to #320. - **Activity:** a refused, allowed or removed grant entry was a bare line. It is now a card like a step and a fact: header (pin icon, what, state chip), dark body (the detail, for a refusal the tool that was refused), footer (kind chip, computer, time). It is a note, so it does not fold; long paths wrap. Demo data has a refused entry. - **Zoom:** the note with the size ("Text size 115%") stays 1.8 s instead of 1.2 s. New setting in Settings > Appearance: "Show the size in a short note when zooming" (on by default, remembered on the device). - Tests: activity.spec (refused card), ux-round2.spec (setting). 38 playwright pass in the four specs touched, tsc clean. Desktop drop: the `dragDropEnabled: false` setting from #320 is compiled into the app, so it only takes effect in a rebuilt desktop app (desktop/install-linux.sh).
ACTIVITY-NOTE, ZOOM-NOTE: a refused, allowed or removed grant is a card like a step (header, dark body, footer); the zoom size note lasts longer and Settings > Appearance can turn it off
Some checks failed
build / skills (pull_request) Successful in 10s
review-gate / sweep (pull_request) Has been cancelled
build / web (pull_request) Successful in 5s
build / runner-windows (pull_request) Successful in 16s
build / runner (pull_request) Successful in 33s
fresh-install / fresh-install (pull_request) Successful in 10s
lint / megalinter (pull_request) Successful in 52s
build / server (pull_request) Successful in 4m3s
kk / all-checks Waiting for: build / web-live (pull_request)
review-gate / gate review findings are all handled
build / web-live (pull_request) Has been cancelled
0ea3135c48
kompas-review scheduled this pull request to auto merge when all checks succeed 2026-10-28 21:00:13 +01:00
Collaborator

Title

ACTIVITY-NOTE, ZOOM-NOTE: refused/allowed entries are cards like steps; zoom size note can be turned off


User description

Follow-up to #320.

  • Activity: a refused, allowed or removed grant entry was a bare line. It is now a card like a step and a fact: header (pin icon, what, state chip), dark body (the detail, for a refusal the tool that was refused), footer (kind chip, computer, time). It is a note, so it does not fold; long paths wrap. Demo data has a refused entry.
  • Zoom: the note with the size ("Text size 115%") stays 1.8 s instead of 1.2 s. New setting in Settings > Appearance: "Show the size in a short note when zooming" (on by default, remembered on the device).
  • Tests: activity.spec (refused card), ux-round2.spec (setting). 38 playwright pass in the four specs touched, tsc clean.

Desktop drop: the dragDropEnabled: false setting from #320 is compiled into the app, so it only takes effect in a rebuilt desktop app (desktop/install-linux.sh).


PR Type

Enhancement, Tests


Description

  • Activity notes now display as card-like steps with headers and footers.

  • Zoom size toast duration increased to 1.8s; setting added to toggle it.

  • Tests updated for new activity note structure and zoom note behavior.


Diagram Walkthrough

flowchart LR
  A["Activity Notes"] -->|"New Card Layout"| B["Step-like Header/Footer"]
  C["Zoom Feature"] -->|"Longer Toast"| D["1.8s Duration"]
  C -->|"Toggle Setting"| E["Settings > Appearance"]
  F["Tests"] -.->|"Verify"| A
  F -.->|"Verify"| C

File Walkthrough

Relevant files
Miscellaneous
1 files
mock.ts
Added mock data entry for refused activity kind                   
+1/-0     
Enhancement
2 files
zoom.ts
Added zoom note toggle logic and longer toast duration     
+11/-1   
activity.ts
Refactored activity items into card-like step layout         
+16/-6   
Configuration changes
1 files
main.ts
Wired zoom note checkbox to settings handler                         
+2/-1     
Documentation
1 files
admin.ts
Added UI checkbox for zoom note setting in admin panel     
+3/-1     
Tests
2 files
activity.spec.ts
Updated tests to reflect new activity note card selectors
+18/-3   
ux-round2.spec.ts
Added test for toggling zoom note visibility in settings 
+23/-0   
Formatting
1 files
styles.css
Styled activity notes with headers, footers, and colors   
+11/-0   

## Title ACTIVITY-NOTE, ZOOM-NOTE: refused/allowed entries are cards like steps; zoom size note can be turned off ___ ### **User description** Follow-up to #320. - **Activity:** a refused, allowed or removed grant entry was a bare line. It is now a card like a step and a fact: header (pin icon, what, state chip), dark body (the detail, for a refusal the tool that was refused), footer (kind chip, computer, time). It is a note, so it does not fold; long paths wrap. Demo data has a refused entry. - **Zoom:** the note with the size ("Text size 115%") stays 1.8 s instead of 1.2 s. New setting in Settings > Appearance: "Show the size in a short note when zooming" (on by default, remembered on the device). - Tests: activity.spec (refused card), ux-round2.spec (setting). 38 playwright pass in the four specs touched, tsc clean. Desktop drop: the `dragDropEnabled: false` setting from #320 is compiled into the app, so it only takes effect in a rebuilt desktop app (desktop/install-linux.sh). ___ ### **PR Type** Enhancement, Tests ___ ### **Description** - Activity notes now display as card-like steps with headers and footers. - Zoom size toast duration increased to 1.8s; setting added to toggle it. - Tests updated for new activity note structure and zoom note behavior. ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Activity Notes"] -->|"New Card Layout"| B["Step-like Header/Footer"] C["Zoom Feature"] -->|"Longer Toast"| D["1.8s Duration"] C -->|"Toggle Setting"| E["Settings > Appearance"] F["Tests"] -.->|"Verify"| A F -.->|"Verify"| C ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Miscellaneous</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>mock.ts</strong><dd><code>Added mock data entry for refused activity kind</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/src/api/mock.ts">+1/-0</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Enhancement</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>zoom.ts</strong><dd><code>Added zoom note toggle logic and longer toast duration</code>&nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/src/core/zoom.ts">+11/-1</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>activity.ts</strong><dd><code>Refactored activity items into card-like step layout</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/src/views/activity.ts">+16/-6</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>main.ts</strong><dd><code>Wired zoom note checkbox to settings handler</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/src/main.ts">+2/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Documentation</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>admin.ts</strong><dd><code>Added UI checkbox for zoom note setting in admin panel</code>&nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/src/views/admin.ts">+3/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>activity.spec.ts</strong><dd><code>Updated tests to reflect new activity note card selectors</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/tests/activity.spec.ts">+18/-3</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>ux-round2.spec.ts</strong><dd><code>Added test for toggling zoom note visibility in settings</code>&nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/tests/ux-round2.spec.ts">+23/-0</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Formatting</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>styles.css</strong><dd><code>Styled activity notes with headers, footers, and colors</code>&nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/activity-notes/web/src/styles.css">+11/-0</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___
Collaborator

PR Reviewer Guide 🔍

(Review updated until commit edc5c7e109)

Here are some key observations to aid the review process:

🔒 No security concerns identified
⚡ No major issues detected
## PR Reviewer Guide 🔍 <!-- pr-agent:review:full --> #### (Review updated until commit https://git.kreative-kompas.com/khyretos/kreative-kompanion/commit/edc5c7e109ba4d4d34974468c93e0c7df82e45a1) Here are some key observations to aid the review process: <table> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>No major issues detected</strong></td></tr> </table>

🧹 Lint report · ❌ 1 problem in 1 check

Errors below fail this check.

Check Errors Warnings Files
❌ JAVA · pmd 1 0 15
JAVA · pmd: first lines of the output
See documentation on https://megalinter.io/9.4.0/descriptors/java_pmd/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kreative-kompanion
Linter raw log:
[WARN] Progressbar rendering conflicts with reporting to STDOUT. No progressbar will be shown. Try running with argument -r <file> to output the report to a file instead.
[WARN] Removed misconfigured rule: LoosePackageCoupling cause: No packages or classes specified
[WARN] This analysis could be faster, please consider using Incremental Analysis: https://docs.pmd-code.org/pmd-doc-7.22.0/pmd_userdocs_incremental_analysis.html
android/app/src/main/java/com/kreativekompas/kompanion/Permissions.java:86:	AvoidDeeplyNestedIfStmts:	Deeply nested if..then statements are hard to read
LoosePackageCoupling	-	No packages or classes specified

✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint

MegaLinter on soucouyant · full logs in the Actions run · comment /improve for AI fix suggestions

<!-- kk-lint --> ## 🧹 Lint report · ❌ 1 problem in 1 check Errors below fail this check. | | Check | Errors | Warnings | Files | |---|---|---:|---:|---:| | ❌ | JAVA · pmd | 1 | 0 | 15 | <details><summary>JAVA · pmd: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/java_pmd/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kreative-kompanion Linter raw log: [WARN] Progressbar rendering conflicts with reporting to STDOUT. No progressbar will be shown. Try running with argument -r <file> to output the report to a file instead. [WARN] Removed misconfigured rule: LoosePackageCoupling cause: No packages or classes specified [WARN] This analysis could be faster, please consider using Incremental Analysis: https://docs.pmd-code.org/pmd-doc-7.22.0/pmd_userdocs_incremental_analysis.html android/app/src/main/java/com/kreativekompas/kompanion/Permissions.java:86: AvoidDeeplyNestedIfStmts: Deeply nested if..then statements are hard to read LoosePackageCoupling - No packages or classes specified ``` </details> ✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint <sub>MegaLinter on soucouyant · full logs in the Actions run · comment <code>/improve</code> for AI fix suggestions</sub>
Phone: plain composer (no lag), microphone permission; smaller card icons; icons in Card colours settings
Some checks failed
build / skills (pull_request) Successful in 11s
build / runner (pull_request) Successful in 8s
build / web (pull_request) Successful in 23s
build / runner-windows (pull_request) Successful in 9s
fresh-install / fresh-install (pull_request) Successful in 34s
review-gate / sweep (pull_request) Successful in 5s
build / server (pull_request) Successful in 3m51s
build / web-live (pull_request) Failing after 27m26s
lint / megalinter (pull_request) Failing after 52s
kk / all-checks Failed: build / web-live (pull_request), lint / megalinter (pull_request)
review-gate / gate review findings are all handled
527abb8822
Collaborator

/review

/review
Android: permissions in their own class (lint); wait for the Card colours rows in the test
Some checks failed
build / skills (pull_request) Successful in 10s
build / runner (pull_request) Successful in 8s
build / web (pull_request) Successful in 21s
build / runner-windows (pull_request) Successful in 9s
review-gate / sweep (pull_request) Has been cancelled
fresh-install / fresh-install (pull_request) Successful in 31s
lint / megalinter (pull_request) Failing after 52s
kk / all-checks Failed: lint / megalinter (pull_request)
build / server (pull_request) Successful in 4m4s
build / web-live (pull_request) Successful in 27m21s
review-gate / gate review findings are all handled
edc5c7e109
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Collaborator

/review

/review
Author
Owner

/review

/review
Collaborator

/review

/review
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
khyretos/kreative-kompanion!321
No description provided.