web: read the attach menu's hidden state as a boolean (TypeScript 6) #367
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "khyretos/ts6-attach-menu-hidden"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Requested by Kees · project thread
The TypeScript 6 update (#366) fails the web typecheck on one line:
menuOpen(attachMenu.hidden)inweb/src/main.ts. In the newer DOM typeshiddenisboolean | 'until-found', and the toggle takes a boolean.attachMenu.hidden !== falsekeeps the behaviour (anything hidden opens the menu) and compiles with TypeScript 5 and 6.🤖 Generated with Claude Code
Title
web: read the attach menu's hidden state as a boolean (TypeScript 6)
PR Type
Bug fix
Description
Fix TypeScript 6 type error in attach menu toggle
Convert hidden state to boolean for menuOpen call
Preserve existing behavior when menu is hidden
Diagram Walkthrough
File Walkthrough
main.ts
Convert hidden state to boolean for TypeScript 6 compatibilityweb/src/main.ts
attachMenu.hiddentoattachMenu.hidden !== falsein eventlistener
PR Reviewer Guide 🔍
Here are some key observations to aid the review process:
🧹 Lint report · ✅ all 25 checks clean
Errors below fail this check.
✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint
MegaLinter on soucouyant · full logs in the Actions run · comment
/improvefor AI fix suggestions