khyretos/kk-engine

Fork 0

WIP: Character creator: archetypes, a clothes browser, necklines and anime clothes #137

Draft

khyretos wants to merge 3 commits from khyretos/claude/creator-polish into claude/creator-wardrobe AGit

khyretos commented

2026-10-27 19:36:21 +01:00

Owner

Stacked on #136 (wardrobe) -> #135 (anime) -> #134 (clothes). Female/Male archetype instead of a gender slider, body types Petite and Model with ideal proportions, smooth necklines, a scrolling clothes grid with 113 generated pictures, and the wardrobe on the VRoid anime avatars. 1351 tests pass. Full body: handoff files/creator-polish-pr.md. Not done: hair (measured fine, needs a screenshot), Blender base models.

khyretos added 1 commit

2026-10-27 19:36:21 +01:00

Character creator: archetypes, a clothes browser, necklines and anime clothes

CI / dependencies (pull_request) Successful in 4s

Details

CI / std-includes (pull_request) Successful in 7s

Details

CI / shipping-build (pull_request) Failing after 2m28s

Details

CI / build-test-and-coverage (pull_request) Failing after 2m1s

Details

Benchmarks / benchmarks (pull_request) Failing after 7m25s

Details

Docs site / site (pull_request) Successful in 39s

Details

CI / android (pull_request) Failing after 2m1s

Details

lint / megalinter (pull_request) Successful in 59s

Details

CI / release-build (pull_request) Failing after 5m49s

Details

Windows (native) / build (pull_request) Failing after 11m31s

Details

Windows (native) / test (pull_request) Has been skipped

Details

Windows (native) / publish (pull_request) Has been skipped

Details

2042d60131

Kees: the characters look like cavemen with odd proportions, gender is an
archetype not a slider, the anime characters have no clothes, only the
turtleneck's neck is right, and the clothes tab bleeds out of the panel
with no way to scroll. All five, one pass.

- Archetype: Female / Male buttons (a whole woman or man, 0 or 1) replace
  the Gender slider; switching re-cuts the body type for the new body and
  swaps the VRoid avatar. A new person starts female, not half way.
  Body types gain Petite and Model and own height and proportions; every
  type starts at proportions 0.7 (towards MakeHuman's ideal, away from its
  heavy-headed middle). Random picks a pure archetype.
- Necklines (crew, scoop, V, deep V) are one smooth curve round the base of
  the neck (Anatomy::collarY), no longer a cut by bone weights, which tore
  the collar wherever neck and torso weights alternate.
- Clothes browser: the panel is a column (a header as tall as its rows
  need, one scrolling area), so nothing bleeds; the Clothes tab is slot
  buttons, dye swatches and a scrolling grid of cards, picture and name.
  tools/garment_thumbs draws the 113 pictures (software rasteriser, no
  GPU); a test fails when a garment has none.
- Anime clothes: dressVrm() cuts every garment from the VRoid avatar's
  skin with the same cuts the realistic body wears (GarmentBody, bones
  named in MakeHuman's words, arms by position along the bone because the
  avatar stands in a T), toon-shaded with an outline in the dye. Skirts,
  dresses and coat tails are a flared skirt skinned to hips and thighs.
  The avatar's own top, trousers and shoes hide when a garment takes their
  place.
- Tests: necklines are ordered curves with nothing over the neck base,
  every garment has a picture, every garment dresses both avatars, stock
  clothes leave and return, skirts wind outward. docs updated.

Not changed: the hair. Measured on the real head (roots, coverage,
simulated strands against the skin) it fits; no fault found without a
screenshot of what looks wrong.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

kompas-review commented

2026-10-27 19:37:16 +01:00

Collaborator

Title

WIP: Character creator: archetypes, a clothes browser, necklines and anime clothes

User description

PR Type

Enhancement

Description

Replaces gender slider with Female/Male archetype buttons
Adds smooth open necklines and a scrolling clothes browser
Enables anime VRoid avatars to wear realistic garment cuts

Diagram Walkthrough

flowchart LR
  A["Character Creator"] -->|"Archetype"| B["Female / Male Buttons"]
  A -->|"Body Type"| C["Average Petite Model Slim"]
  A -->|"Necklines"| D["Smooth Crew Scoop V DeepV"]
  A -->|"Clothes"| E["Scrolling Grid Browser"]
  A -->|"Anime Mode"| F["VRoid Avatar Dressing"]
  E -.->|"Thumbnails"| G["tools/garment_thumbs"]
  F -.->|"Cuts from Skin"| H["HumanClothes Logic"]

File Walkthrough

Relevant files

Enhancement

9 files

HumanClothes.cpp `Refactors anatomy for smooth necklines and GarmentBody support`	+103/-23
VrmClothes.cpp `Implements VRoid avatar dressing with garment cuts and skirts`	+273/-0
CharacterCreatorModule.cpp `Adds archetype buttons body type presets and clothes browser`	+103/-13
main.cpp `Generates garment thumbnails via software rasterizer`	+164/-0
HumanClothes.h `Defines GarmentBody struct and new garment piece functions`	+22/-0
VrmClothes.h `Declares VrmStock and dressVrm function for anime avatars`	+42/-0
CharacterCreatorModule.h `Adds archetype body type and outfit tracking fields`	+10/-2
creator.rcss `Restructures panel as column with scrolling clothes grid`	+24/-4
creator.rml `Adds archetype buttons slot tabs and card-based clothes view`	+73/-87

Tests

2 files

test_human.cpp `Tests neckline curves and garment thumbnail existence`	+51/-0
test_vrm_clothes.cpp `Validates VRoid avatar dressing and skirt winding`	+97/-0

Configuration changes

1 files

CMakeLists.txt
Builds garment_thumbs tool and copies thumbnail assets +7/-0

Documentation

5 files

LICENSE.txt `Licenses creator UI and generated garment thumbnails`	+5/-0
ANIME.md `Documents anime clothes system and VRoid avatar dressing`	+18/-2
DEPENDENCIES.md `Updates character creator asset list with thumbnails`	+1/-1
HUMANS.md `Explains clothes browser layout and neckline fixes`	+13/-0
README.md `Updates feature list to include archetypes and anime`	+15/-9

Additional files

3 files

CMakeLists.txt	+1/-0
CMakeLists.txt	+1/-0
CMakeLists.txt	+2/-0

## Title WIP: Character creator: archetypes, a clothes browser, necklines and anime clothes ___ ### **User description** Stacked on #136 (wardrobe) -> #135 (anime) -> #134 (clothes). Female/Male archetype instead of a gender slider, body types Petite and Model with ideal proportions, smooth necklines, a scrolling clothes grid with 113 generated pictures, and the wardrobe on the VRoid anime avatars. 1351 tests pass. Full body: handoff files/creator-polish-pr.md. Not done: hair (measured fine, needs a screenshot), Blender base models. ___ ### **PR Type** Enhancement ___ ### **Description** - Replaces gender slider with Female/Male archetype buttons - Adds smooth open necklines and a scrolling clothes browser - Enables anime VRoid avatars to wear realistic garment cuts ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Character Creator"] -->|"Archetype"| B["Female / Male Buttons"] A -->|"Body Type"| C["Average Petite Model Slim"] A -->|"Necklines"| D["Smooth Crew Scoop V DeepV"] A -->|"Clothes"| E["Scrolling Grid Browser"] A -->|"Anime Mode"| F["VRoid Avatar Dressing"] E -.->|"Thumbnails"| G["tools/garment_thumbs"] F -.->|"Cuts from Skin"| H["HumanClothes Logic"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>9 files</summary><table> <tr> <td><strong>HumanClothes.cpp</strong><dd><code>Refactors anatomy for smooth necklines and GarmentBody support</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/src/HumanClothes.cpp">+103/-23</a></td> </tr> <tr> <td><strong>VrmClothes.cpp</strong><dd><code>Implements VRoid avatar dressing with garment cuts and skirts</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/src/VrmClothes.cpp">+273/-0</a>  </td> </tr> <tr> <td><strong>CharacterCreatorModule.cpp</strong><dd><code>Adds archetype buttons body type presets and clothes browser</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/src/modules/CharacterCreatorModule.cpp">+103/-13</a></td> </tr> <tr> <td><strong>main.cpp</strong><dd><code>Generates garment thumbnails via software rasterizer</code>          </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/tools/garment_thumbs/main.cpp">+164/-0</a>  </td> </tr> <tr> <td><strong>HumanClothes.h</strong><dd><code>Defines GarmentBody struct and new garment piece functions</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/include/kke/HumanClothes.h">+22/-0</a>    </td> </tr> <tr> <td><strong>VrmClothes.h</strong><dd><code>Declares VrmStock and dressVrm function for anime avatars</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/include/kke/VrmClothes.h">+42/-0</a>    </td> </tr> <tr> <td><strong>CharacterCreatorModule.h</strong><dd><code>Adds archetype body type and outfit tracking fields</code>            </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/include/kke/modules/CharacterCreatorModule.h">+10/-2</a>    </td> </tr> <tr> <td><strong>creator.rcss</strong><dd><code>Restructures panel as column with scrolling clothes grid</code>  </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/assets/ui/character_creator/creator.rcss">+24/-4</a>    </td> </tr> <tr> <td><strong>creator.rml</strong><dd><code>Adds archetype buttons slot tabs and card-based clothes view</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/assets/ui/character_creator/creator.rml">+73/-87</a>  </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>test_human.cpp</strong><dd><code>Tests neckline curves and garment thumbnail existence</code>        </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/tests/test_human.cpp">+51/-0</a>    </td> </tr> <tr> <td><strong>test_vrm_clothes.cpp</strong><dd><code>Validates VRoid avatar dressing and skirt winding</code>                </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/tests/test_vrm_clothes.cpp">+97/-0</a>    </td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>CMakeLists.txt</strong><dd><code>Builds garment_thumbs tool and copies thumbnail assets</code>      </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/CMakeLists.txt">+7/-0</a>      </td> </tr> </table></details></td></tr><tr><td><strong>Documentation</strong></td><td><details><summary>5 files</summary><table> <tr> <td><strong>LICENSE.txt</strong><dd><code>Licenses creator UI and generated garment thumbnails</code>          </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/assets/ui/character_creator/LICENSE.txt">+5/-0</a>      </td> </tr> <tr> <td><strong>ANIME.md</strong><dd><code>Documents anime clothes system and VRoid avatar dressing</code>  </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/docs/ANIME.md">+18/-2</a>    </td> </tr> <tr> <td><strong>DEPENDENCIES.md</strong><dd><code>Updates character creator asset list with thumbnails</code>          </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/docs/DEPENDENCIES.md">+1/-1</a>      </td> </tr> <tr> <td><strong>HUMANS.md</strong><dd><code>Explains clothes browser layout and neckline fixes</code>              </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/docs/HUMANS.md">+13/-0</a>    </td> </tr> <tr> <td><strong>README.md</strong><dd><code>Updates feature list to include archetypes and anime</code>          </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/games/character_creator/README.md">+15/-9</a>    </td> </tr> </table></details></td></tr><tr><td><strong>Additional files</strong></td><td><details><summary>3 files</summary><table> <tr> <td><strong>CMakeLists.txt</strong></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/CMakeLists.txt">+1/-0</a>      </td> </tr> <tr> <td><strong>CMakeLists.txt</strong></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/tests/CMakeLists.txt">+1/-0</a>      </td> </tr> <tr> <td><strong>CMakeLists.txt</strong></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/tools/garment_thumbs/CMakeLists.txt">+2/-0</a>      </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___

kompas-review commented

2026-10-27 19:37:56 +01:00

Collaborator

PR Reviewer Guide 🔍

(Review updated until commit `b89aee690c`)

📋 Focus areas: 🔴 5 open · ✅ 8 handled. Every push re-checks them; a handled area moves to Resolved findings at the bottom.

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Incorrect Default Offset for 'top' Function

The default value for the offset parameter in the top function was changed from 0.003f to 0.0075f. This change affects all new top garments that do not explicitly specify an offset, potentially altering their fit relative to the body suit compared to previous behavior or expectations.

float offset = 0.0075f) {

Hard-coded Gender Initialization

In init(), the code sets m_human->set("macrodetails/Gender", 0.0f) unconditionally. While this is immediately overridden by the applyArchetype call if the KKE_CREATOR_GENDER environment variable is set, this initialization order creates a race condition where the human model is temporarily forced into female before the archetype logic runs. If the environment variable is missing or empty, the gender remains female. This hard-coding contradicts the PR description's intent of "Female/Male archetype instead of a gender slider" and should be removed or made conditional to avoid unintended side effects during initialization.

m_human->set("macrodetails/Gender", 0.0f); // a new person is a woman or a man, not half way: Female / Male buttons

Missing Error Handling for Garment Loading

The dressVrm function iterates over clothes and calls findGarment(w.id). If a garment ID is invalid or the file is missing, findGarment returns nullptr, causing the loop to silently skip that garment without logging a warning or error. This makes debugging wardrobe issues difficult as the user might expect a specific item to appear but see nothing with no indication of why.

const GarmentInfo* info = findGarment(w.id);
if (!info) continue;

Silent Failure on Missing Garments

The tool checks if a garment exists using findGarment(id), but if it doesn't, it prints an error message and returns 1. However, if the tool is run without arguments (generating thumbnails for all garments), it relies on garments() which might return empty or fail silently depending on implementation details not visible here. More critically, if a specific garment ID is passed that doesn't exist, the tool exits with an error code, which is correct, but the lack of a try-catch block around the main logic means any unexpected exception will crash the tool rather than being handled gracefully.

for (const std::string& id : ids) {
    const kke::GarmentInfo* info = kke::findGarment(id);
    if (!info) {
        std::fprintf(stderr, "no garment '%s'\n", id.c_str());
        return 1;
    }
    kke::ModelData model = body.model;
    const size_t first = model.meshes.size();
    kke::dress(model, human, { { id, info->colour } }, false);
    if (model.meshes.size() == first) {
        std::fprintf(stderr, "'%s' has no pieces\n", id.c_str());
        return 1;
    }

Hardcoded hairline threshold
The hairstyleOnHead function in HumanHair.cpp uses a hardcoded hairline = 1.0f parameter when calling itself (line 107). This value is passed to the function signature which defaults to 1.0f if not provided, but the comment above the function declaration suggests it represents "how far down the forehead it grows". A fixed value of 1.0f may not correctly handle different head shapes or hairstyles that require varying hairline positions. The code should either pass an appropriate calculated value or allow the caller to specify this parameter explicitly based on the hairstyle type.

ℹ️ Chunked review: the diff exceeded the model token budget, so it was reviewed in 2 chunks and the per-chunk results were merged.

✅ Resolved findings

tools/garment_thumbs/main.cpp:80-81

Hardcoded gender and proportions for thumbnails

The thumbnail generator hardcodes Gender to 0.0f (female) and BodyProportions to 0.7f (Model). This means thumbnails for male archetypes or other body types will always be generated using the female Model body. This creates a mismatch between the actual available clothes (which support male archetypes) and their preview images, potentially misleading users about how clothes fit different archetypes.

tests/test_vrm_clothes.cpp:14-16

Missing Error Handling for File Loading

The test function avatar calls kke::loadVrm with a constructed file path. If the asset files (e.g., "HairSample_Female.vrm") are missing from the build directory or the path is incorrect, loadVrm will likely return an invalid or null avatar object. The subsequent code accesses members of this object (like a.model.meshes) without checking if the load succeeded. This could lead to undefined behavior, crashes, or silent test failures depending on how loadVrm handles errors. The test should verify that the avatar loaded successfully before proceeding with assertions.

engine/src/HumanClothes.cpp:46

Incorrect default offset for 'top' garments

The default offset parameter in the top function was changed from 0.003f to 0.0075f. This affects all top garments that do not explicitly specify an offset (e.g., "t-shirt", "polo"). While this might be intentional for visual spacing, it is a significant change to the default behavior of existing garment definitions and could cause tops to sit too far out on the body unless carefully audited.

engine/src/HumanHair.cpp:88

Potential Logic Error in Hair Growth Condition

Line 88 introduces a new condition for hair growth (grows). The logic above > 0.18f - 0.25f * std::clamp(-forward - 0.6f, 0.0f, 1.0f) calculates a threshold based on the forward vector. While the intent seems to be adjusting the growth threshold based on forehead position, the term -0.25f * ... subtracts a positive value from 0.18f. This lowers the threshold as forward becomes more negative (further back on the head). It is unclear if this specific mathematical relationship correctly models the desired hairline geometry compared to the previous hardcoded 0.62f for the forehead. Without a visual reference or detailed geometric analysis, it's difficult to confirm this change doesn't cause hair to grow in unintended areas or fail to grow where it should.

engine/src/VrmClothes.cpp:42

Missing fallback for missing skin meshes

In the prepare function, if st.skinMeshes is empty, the function returns early without populating the body structure. Later, garmentPiecesOn calls garmentSkirt which accesses st.body. If st.body is uninitialized or incomplete due to the early return, accessing its members (like waist, sole) could lead to undefined behavior or incorrect calculations when dressing VRoid avatars that lack a skin mesh group.

engine/src/modules/CharacterCreatorModule.cpp:382-386

Missing Error Handling for Environment Variables

The code reads environment variables KKE_CREATOR_GENDER, KKE_CREATOR_PRESET, and KKE_CREATOR_CLOTHES without checking if they are null or empty before parsing. If an environment variable is set to an invalid string (e.g., "abc" for GENDER), std::strtof will return 0.0f, potentially causing unexpected behavior like defaulting to female when a user intended to set a specific value or pass garbage data. While the impact might be limited to defaulting, explicit validation improves robustness.

engine/src/modules/CharacterCreatorModule.cpp:966

Potential Logic Error in Archetype Application

In applyArchetype, the function calls setBodyType(m_bodyType) to apply the build sliders. However, setBodyType resets all sliders to their default values before applying the preset's specific values. This means that if a user has manually adjusted individual sliders (like Muscle or Weight) before switching archetypes, those manual adjustments will be lost when the archetype changes, even though the body type name remains the same. The logic assumes the body type definition is the sole source of truth for the build, ignoring intermediate user modifications.

tests/test_human.cpp:640

Hardcoded Path Dependency in Test

The test EveryGarmentHasAThumbnail uses KKE_SOURCE_DIR to locate thumbnail files. If this macro is not defined correctly in the test build configuration or if the test is run from a different directory structure than expected, the test will fail with a false negative regarding missing thumbnails rather than reporting the actual issue. It is better to use a relative path or ensure the macro is guaranteed to be set in the test environment.

## PR Reviewer Guide 🔍  #### (Review updated until commit https://git.kreative-kompas.com/khyretos/kk-engine/commit/b89aee690c8a2261e4929d0f0989288bc547af69) 📋 **Focus areas:** 🔴 5 open · ✅ 8 handled. Every push re-checks them; a handled area moves to *Resolved findings* at the bottom. <table> <tr><td>⏱️ <strong>Estimated effort to review</strong>: 3 🔵🔵🔵⚪⚪</td></tr> <tr><td>🧪 <strong>PR contains tests</strong></td></tr> <tr><td>🔒 <strong>No security concerns identified</strong></td></tr> <tr><td>⚡ <strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/src/HumanClothes.cpp#L46-L46'><strong>Incorrect Default Offset for 'top' Function</strong></a> The default value for the `offset` parameter in the `top` function was changed from `0.003f` to `0.0075f`. This change affects all new top garments that do not explicitly specify an offset, potentially altering their fit relative to the body suit compared to previous behavior or expectations. </summary> ```c++ float offset = 0.0075f) { ``` </details> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/src/modules/CharacterCreatorModule.cpp#L336-L336'><strong>Hard-coded Gender Initialization</strong></a> In `init()`, the code sets `m_human->set("macrodetails/Gender", 0.0f)` unconditionally. While this is immediately overridden by the `applyArchetype` call if the `KKE_CREATOR_GENDER` environment variable is set, this initialization order creates a race condition where the human model is temporarily forced into female before the archetype logic runs. If the environment variable is missing or empty, the gender remains female. This hard-coding contradicts the PR description's intent of "Female/Male archetype instead of a gender slider" and should be removed or made conditional to avoid unintended side effects during initialization. </summary> ```c++ m_human->set("macrodetails/Gender", 0.0f); // a new person is a woman or a man, not half way: Female / Male buttons ``` </details> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/engine/src/VrmClothes.cpp#L230-L231'><strong>Missing Error Handling for Garment Loading</strong></a> The `dressVrm` function iterates over clothes and calls `findGarment(w.id)`. If a garment ID is invalid or the file is missing, `findGarment` returns `nullptr`, causing the loop to silently skip that garment without logging a warning or error. This makes debugging wardrobe issues difficult as the user might expect a specific item to appear but see nothing with no indication of why. </summary> ```c++ const GarmentInfo* info = findGarment(w.id); if (!info) continue; ``` </details> <details><summary><a href='https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/refs/pull/137/head/tools/garment_thumbs/main.cpp#L93-L105'><strong>Silent Failure on Missing Garments</strong></a> The tool checks if a garment exists using `findGarment(id)`, but if it doesn't, it prints an error message and returns `1`. However, if the tool is run without arguments (generating thumbnails for all garments), it relies on `garments()` which might return empty or fail silently depending on implementation details not visible here. More critically, if a specific garment ID is passed that doesn't exist, the tool exits with an error code, which is correct, but the lack of a try-catch block around the main logic means any unexpected exception will crash the tool rather than being handled gracefully. </summary> ```c++ for (const std::string& id : ids) { const kke::GarmentInfo* info = kke::findGarment(id); if (!info) { std::fprintf(stderr, "no garment '%s'\n", id.c_str()); return 1; } kke::ModelData model = body.model; const size_t first = model.meshes.size(); kke::dress(model, human, { { id, info->colour } }, false); if (model.meshes.size() == first) { std::fprintf(stderr, "'%s' has no pieces\n", id.c_str()); return 1; } ``` </details> <strong>Hardcoded hairline threshold</strong><br>The `hairstyleOnHead` function in HumanHair.cpp uses a hardcoded `hairline = 1.0f` parameter when calling itself (line 107). This value is passed to the function signature which defaults to `1.0f` if not provided, but the comment above the function declaration suggests it represents "how far down the forehead it grows". A fixed value of 1.0f may not correctly handle different head shapes or hairstyles that require varying hairline positions. The code should either pass an appropriate calculated value or allow the caller to specify this parameter explicitly based on the hairstyle type. </td></tr> </table> <hr> ℹ️ **Chunked review:** the diff exceeded the model token budget, so it was reviewed in 2 chunks and the per-chunk results were merged. <details> <summary>✅ Resolved findings</summary> ### tools/garment_thumbs/main.cpp:80-81 **Hardcoded gender and proportions for thumbnails** The thumbnail generator hardcodes `Gender` to `0.0f` (female) and `BodyProportions` to `0.7f` (Model). This means thumbnails for male archetypes or other body types will always be generated using the female Model body. This creates a mismatch between the actual available clothes (which support male archetypes) and their preview images, potentially misleading users about how clothes fit different archetypes. ### tests/test_vrm_clothes.cpp:14-16 **Missing Error Handling for File Loading** The test function `avatar` calls `kke::loadVrm` with a constructed file path. If the asset files (e.g., "HairSample_Female.vrm") are missing from the build directory or the path is incorrect, `loadVrm` will likely return an invalid or null avatar object. The subsequent code accesses members of this object (like `a.model.meshes`) without checking if the load succeeded. This could lead to undefined behavior, crashes, or silent test failures depending on how `loadVrm` handles errors. The test should verify that the avatar loaded successfully before proceeding with assertions. ### engine/src/HumanClothes.cpp:46 **Incorrect default offset for 'top' garments** The default `offset` parameter in the `top` function was changed from `0.003f` to `0.0075f`. This affects all top garments that do not explicitly specify an offset (e.g., "t-shirt", "polo"). While this might be intentional for visual spacing, it is a significant change to the default behavior of existing garment definitions and could cause tops to sit too far out on the body unless carefully audited. ### engine/src/HumanHair.cpp:88 **Potential Logic Error in Hair Growth Condition** Line 88 introduces a new condition for hair growth (`grows`). The logic `above > 0.18f - 0.25f * std::clamp(-forward - 0.6f, 0.0f, 1.0f)` calculates a threshold based on the `forward` vector. While the intent seems to be adjusting the growth threshold based on forehead position, the term `-0.25f * ...` subtracts a positive value from `0.18f`. This lowers the threshold as `forward` becomes more negative (further back on the head). It is unclear if this specific mathematical relationship correctly models the desired hairline geometry compared to the previous hardcoded `0.62f` for the forehead. Without a visual reference or detailed geometric analysis, it's difficult to confirm this change doesn't cause hair to grow in unintended areas or fail to grow where it should. ### engine/src/VrmClothes.cpp:42 **Missing fallback for missing skin meshes** In the `prepare` function, if `st.skinMeshes` is empty, the function returns early without populating the `body` structure. Later, `garmentPiecesOn` calls `garmentSkirt` which accesses `st.body`. If `st.body` is uninitialized or incomplete due to the early return, accessing its members (like `waist`, `sole`) could lead to undefined behavior or incorrect calculations when dressing VRoid avatars that lack a skin mesh group. ### engine/src/modules/CharacterCreatorModule.cpp:382-386 **Missing Error Handling for Environment Variables** The code reads environment variables `KKE_CREATOR_GENDER`, `KKE_CREATOR_PRESET`, and `KKE_CREATOR_CLOTHES` without checking if they are null or empty before parsing. If an environment variable is set to an invalid string (e.g., "abc" for GENDER), `std::strtof` will return 0.0f, potentially causing unexpected behavior like defaulting to female when a user intended to set a specific value or pass garbage data. While the impact might be limited to defaulting, explicit validation improves robustness. ### engine/src/modules/CharacterCreatorModule.cpp:966 **Potential Logic Error in Archetype Application** In `applyArchetype`, the function calls `setBodyType(m_bodyType)` to apply the build sliders. However, `setBodyType` resets all sliders to their default values before applying the preset's specific values. This means that if a user has manually adjusted individual sliders (like Muscle or Weight) before switching archetypes, those manual adjustments will be lost when the archetype changes, even though the body type name remains the same. The logic assumes the body type definition is the sole source of truth for the build, ignoring intermediate user modifications. ### tests/test_human.cpp:640 **Hardcoded Path Dependency in Test** The test `EveryGarmentHasAThumbnail` uses `KKE_SOURCE_DIR` to locate thumbnail files. If this macro is not defined correctly in the test build configuration or if the test is run from a different directory structure than expected, the test will fail with a false negative regarding missing thumbnails rather than reporting the actual issue. It is better to use a relative path or ensure the macro is guaranteed to be set in the test environment. </details>

kompas-review commented

2026-10-27 19:38:15 +01:00

Collaborator

PR Code Suggestions ✨

No code suggestions found for the PR.

## PR Code Suggestions ✨  No code suggestions found for the PR.

forgejo-actions commented

2026-10-27 19:47:15 +01:00

🧹 Lint report · ❌ 38 problems in 6 checks · 🧹 3 formatting checks to tidy

Nothing here blocks the merge (report only).

	Check	Errors	Files
❌	MARKDOWN · markdownlint	24	255
❌	CPP · cppcheck	9	957
❌	YAML · yamllint	2	57
❌	BASH · shellcheck	1	11
❌	DOCKERFILE · hadolint	1	9
❌	REPOSITORY · trivy	1	–

MARKDOWN · markdownlint: first lines of the output

See documentation on https://megalinter.io/9.4.0/descriptors/markdown_markdownlint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
docs/ANDROID.md:87 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:128 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:136 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:149 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:163 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:186 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ASSETS.md:155 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
docs/HISTORY.md:21 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: " Kreative Kompas Engine (KKE)"]
docs/HISTORY.md:520 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:727 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:734 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:2031 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:2090 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/MODDING.md:13 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/NETWORKING.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PLATFORMS.md:48 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PROCEDURAL_ANIMATION.md:36 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PROCEDURAL_ANIMATION.md:284 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
games/racing/README.md:34 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
games/racing/README.md:76:91 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
games/racing/README.md:77:89 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
…

CPP · cppcheck: first lines of the output

See documentation on https://megalinter.io/9.4.0/descriptors/cpp_cppcheck/
-----------------------------------------------
✅ [SUCCESS] benchmarks/kke_bench/main.cpp
✅ [SUCCESS] benchmarks/kke_benchmark/main.cpp
✅ [SUCCESS] engine/include/engine/Buffer.h
✅ [SUCCESS] engine/include/engine/Mesh.h
✅ [SUCCESS] engine/include/engine/Pipeline.h
✅ [SUCCESS] engine/include/engine/Renderer.h
✅ [SUCCESS] engine/include/engine/SwapChain.h
✅ [SUCCESS] engine/include/engine/VulkanCheck.h
✅ [SUCCESS] engine/include/engine/VulkanDevice.h
✅ [SUCCESS] engine/include/engine/Window.h
✅ [SUCCESS] engine/include/kke/AnimEvents.h
✅ [SUCCESS] engine/include/kke/AnimRig.h
✅ [SUCCESS] engine/include/kke/Animator.h
✅ [SUCCESS] engine/include/kke/AnimeRenderer.h
✅ [SUCCESS] engine/include/kke/Application.h
✅ [SUCCESS] engine/include/kke/AssetCatalog.h
✅ [SUCCESS] engine/include/kke/AudioMixer.h
✅ [SUCCESS] engine/include/kke/AutoRig.h
✅ [SUCCESS] engine/include/kke/BenchRecorder.h
✅ [SUCCESS] engine/include/kke/BenchmarkReport.h
✅ [SUCCESS] engine/include/kke/Bloom.h
✅ [SUCCESS] engine/include/kke/BodyShape.h
✅ [SUCCESS] engine/include/kke/BreakGraph.h
…

YAML · yamllint: first lines of the output

See documentation on https://megalinter.io/9.4.0/descriptors/yaml_yamllint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
games/goblin_horde/data/heroes.yml
  53:11     error    too many spaces after colon  (colons)
  63:11     error    too many spaces after colon  (colons)

BASH · shellcheck: first lines of the output

See documentation on https://megalinter.io/9.4.0/descriptors/bash_shellcheck/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
In tools/packaging/package.sh line 130:
	done < <(find "$stage" "$stage/benchmark" -maxdepth 1 -type f \( -name "*$exe" -o -name '*.dll' \) $([ -z "$exe" ] && echo "-perm -u+x") -print0)
                                                                                                           ^-- SC2046 (warning): Quote this to prevent word splitting.
For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

DOCKERFILE · hadolint: first lines of the output

See documentation on https://megalinter.io/9.4.0/descriptors/dockerfile_hadolint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
docker/android.Dockerfile:19 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:38 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.
docker/appimage.Dockerfile:51 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:57 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:63 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:63 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:73 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:73 DL3003 warning: Use WORKDIR to switch to a directory
docker/ci.Dockerfile:42 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/ci.Dockerfile:56 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/server/Dockerfile:22 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/vm.Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
docker/vm.Dockerfile:29 DL3003 warning: Use WORKDIR to switch to a directory
docker/vm.Dockerfile:29 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
website/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check

REPOSITORY · trivy: first lines of the output

See documentation on https://megalinter.io/9.4.0/descriptors/repository_trivy/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
2026-10-27T20:53:47Z	INFO	[vulndb] Need to update DB
2026-10-27T20:53:47Z	INFO	[vulndb] Downloading vulnerability DB...
2026-10-27T20:53:47Z	INFO	[vulndb] Downloading artifact...	repo="mirror.gcr.io/aquasec/trivy-db:2"
19.86 MiB / 130.09 MiB [--------->__________________________________________________] 15.26% ? p/s ?35.59 MiB / 130.09 MiB [---------------->___________________________________________] 27.36% ? p/s ?43.28 MiB / 130.09 MiB [------------------->________________________________________] 33.27% ? p/s ?51.15 MiB / 130.09 MiB [------------------>____________________________] 39.32% 52.13 MiB p/s ETA 1s59.19 MiB / 130.09 MiB [--------------------->_________________________] 45.50% 52.13 MiB p/s ETA 1s66.70 MiB / 130.09 MiB [------------------------>______________________] 51.27% 52.13 MiB p/s ETA 1s73.99 MiB / 130.09 MiB [-------------------------->____________________] 56.88% 51.22 MiB p/s ETA 1s81.85 MiB / 130.09 MiB [----------------------------->_________________] 62.92% 51.22 MiB p/s ETA 0s89.76 MiB / 130.09 MiB [-------------------------------->______________] 69.00% 51.22 MiB p/s ETA 0s97.41 MiB / 130.09 MiB [----------------------------------->___________] 74.88% 50.43 MiB p/s ETA 0s104.78 MiB / 130.09 MiB [------------------------------------->________] 80.55% 50.43 MiB p/s ETA 0s111.96 MiB / 130.09 MiB [--------------------------------------->______] 86.07% 50.43 MiB p/s ETA 0s119.40 MiB / 130.09 MiB [------------------------------------------>___] 91.79% 49.54 MiB p/s ETA 0s126.71 MiB / 130.09 MiB [-------------------------------------------->_] 97.41% 49.54 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 49.54 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 47.50 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 47.50 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 47.50 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 44.43 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 44.43 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 44.43 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 41.57 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 41.57 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 41.57 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 38.88 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 38.88 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 38.88 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 36.38 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 36.38 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 36.38 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 34.03 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 34.03 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 34.03 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 31.83 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 31.83 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 31.83 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 29.78 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 29.78 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 29.78 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 27.86 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 27.86 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 27.86 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-----------------------------------------------] 100.00% 15.78 MiB p/s 8.4s2026-10-27T20:53:56Z	INFO	[vulndb] Artifact successfully downloaded	repo="mirror.gcr.io/aquasec/trivy-db:2"
2026-10-27T20:53:56Z	INFO	[vuln] Vulnerability scanning is enabled
2026-10-27T20:53:56Z	INFO	[misconfig] Misconfiguration scanning is enabled
2026-10-27T20:53:56Z	INFO	[checks-client] Need to update the checks bundle
2026-10-27T20:53:56Z	INFO	[checks-client] Downloading the checks bundle...
234.57 KiB / 234.57 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2026-10-27T20:53:57Z	WARN	[rego] Module will be skipped as current version of Trivy is older than minimum trivy version required - please update Trivy to use this module	file_path="root/.cache/trivy/policy/content/policies/cloud/policies/aws/cloudfront/enable_logging.rego" minimum_trivy_version="0.72.0"
2026-10-27T20:53:58Z	ERROR	[dockerfile scanner] Failed to parse file	file_path="docker/server/Dockerfile.dockerignore" err="parse dockerfile instruction: parse instruction \".git\": unknown instruction: .git"
2026-10-27T20:53:58Z	INFO	Number of language-specific files	num=0
2026-10-27T20:53:58Z	INFO	Detected config files	num=9
Report Summary
┌──────────────────────────────┬────────────┬─────────────────┬───────────────────┐
│            Target            │    Type    │ Vulnerabilities │ Misconfigurations │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ benchmarks/docker/Dockerfile │ dockerfile │        -        │         2         │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ docker/android.Dockerfile    │ dockerfile │        -        │         2         │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ docker/appimage.Dockerfile   │ dockerfile │        -        │         5         │
…

🧹 Formatting only (layout, no behaviour; the nightly lint-fix job applies these as a PR): YAML · prettier (57 files checked), BASH · shfmt (11 files checked), JSON · prettier (147 files checked)

✅ Clean: actionlint, git_diff, gitleaks, grype, jsonlint, secretlint, stylelint, trufflehog, xmllint

_{MegaLinter on soucouyant · full logs in the Actions run · comment /improve for AI fix suggestions}

## 🧹 Lint report · ❌ 38 problems in 6 checks · 🧹 3 formatting checks to tidy Nothing here blocks the merge (report only). | | Check | Errors | Warnings | Files | |---|---|---:|---:|---:| | ❌ | MARKDOWN · markdownlint | 24 | 0 | 255 | | ❌ | CPP · cppcheck | 9 | 0 | 957 | | ❌ | YAML · yamllint | 2 | 0 | 57 | | ❌ | BASH · shellcheck | 1 | 0 | 11 | | ❌ | DOCKERFILE · hadolint | 1 | 0 | 9 | | ❌ | REPOSITORY · trivy | 1 | 0 | – | <details><summary>MARKDOWN · markdownlint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/markdown_markdownlint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: docs/ANDROID.md:87 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:128 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:136 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:149 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:163 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:186 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ASSETS.md:155 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented] docs/HISTORY.md:21 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: " Kreative Kompas Engine (KKE)"] docs/HISTORY.md:520 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:727 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:734 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:2031 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:2090 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/MODDING.md:13 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/NETWORKING.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PLATFORMS.md:48 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PROCEDURAL_ANIMATION.md:36 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PROCEDURAL_ANIMATION.md:284 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] games/racing/README.md:34 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] games/racing/README.md:76:91 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] games/racing/README.md:77:89 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] … ``` </details> <details><summary>CPP · cppcheck: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/cpp_cppcheck/ ----------------------------------------------- ✅ [SUCCESS] benchmarks/kke_bench/main.cpp ✅ [SUCCESS] benchmarks/kke_benchmark/main.cpp ✅ [SUCCESS] engine/include/engine/Buffer.h ✅ [SUCCESS] engine/include/engine/Mesh.h ✅ [SUCCESS] engine/include/engine/Pipeline.h ✅ [SUCCESS] engine/include/engine/Renderer.h ✅ [SUCCESS] engine/include/engine/SwapChain.h ✅ [SUCCESS] engine/include/engine/VulkanCheck.h ✅ [SUCCESS] engine/include/engine/VulkanDevice.h ✅ [SUCCESS] engine/include/engine/Window.h ✅ [SUCCESS] engine/include/kke/AnimEvents.h ✅ [SUCCESS] engine/include/kke/AnimRig.h ✅ [SUCCESS] engine/include/kke/Animator.h ✅ [SUCCESS] engine/include/kke/AnimeRenderer.h ✅ [SUCCESS] engine/include/kke/Application.h ✅ [SUCCESS] engine/include/kke/AssetCatalog.h ✅ [SUCCESS] engine/include/kke/AudioMixer.h ✅ [SUCCESS] engine/include/kke/AutoRig.h ✅ [SUCCESS] engine/include/kke/BenchRecorder.h ✅ [SUCCESS] engine/include/kke/BenchmarkReport.h ✅ [SUCCESS] engine/include/kke/Bloom.h ✅ [SUCCESS] engine/include/kke/BodyShape.h ✅ [SUCCESS] engine/include/kke/BreakGraph.h … ``` </details> <details><summary>YAML · yamllint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/yaml_yamllint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: games/goblin_horde/data/heroes.yml 53:11 error too many spaces after colon (colons) 63:11 error too many spaces after colon (colons) ``` </details> <details><summary>BASH · shellcheck: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/bash_shellcheck/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: In tools/packaging/package.sh line 130: done < <(find "$stage" "$stage/benchmark" -maxdepth 1 -type f $ -name "*$exe" -o -name '*.dll' $ $([ -z "$exe" ] && echo "-perm -u+x") -print0) ^-- SC2046 (warning): Quote this to prevent word splitting. For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... ``` </details> <details><summary>DOCKERFILE · hadolint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/dockerfile_hadolint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: docker/android.Dockerfile:19 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:38 SC2016 info: Expressions don't expand in single quotes, use double quotes for that. docker/appimage.Dockerfile:51 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:57 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:63 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:63 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:73 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:73 DL3003 warning: Use WORKDIR to switch to a directory docker/ci.Dockerfile:42 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/ci.Dockerfile:56 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/server/Dockerfile:22 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/vm.Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting. docker/vm.Dockerfile:29 DL3003 warning: Use WORKDIR to switch to a directory docker/vm.Dockerfile:29 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check website/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check ``` </details> <details><summary>REPOSITORY · trivy: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/repository_trivy/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: 2026-10-27T20:53:47Z INFO [vulndb] Need to update DB 2026-10-27T20:53:47Z INFO [vulndb] Downloading vulnerability DB... 2026-10-27T20:53:47Z INFO [vulndb] Downloading artifact... repo="mirror.gcr.io/aquasec/trivy-db:2" 19.86 MiB / 130.09 MiB [--------->__________________________________________________] 15.26% ? p/s ?35.59 MiB / 130.09 MiB [---------------->___________________________________________] 27.36% ? p/s ?43.28 MiB / 130.09 MiB [------------------->________________________________________] 33.27% ? p/s ?51.15 MiB / 130.09 MiB [------------------>____________________________] 39.32% 52.13 MiB p/s ETA 1s59.19 MiB / 130.09 MiB [--------------------->_________________________] 45.50% 52.13 MiB p/s ETA 1s66.70 MiB / 130.09 MiB [------------------------>______________________] 51.27% 52.13 MiB p/s ETA 1s73.99 MiB / 130.09 MiB [-------------------------->____________________] 56.88% 51.22 MiB p/s ETA 1s81.85 MiB / 130.09 MiB [----------------------------->_________________] 62.92% 51.22 MiB p/s ETA 0s89.76 MiB / 130.09 MiB [-------------------------------->______________] 69.00% 51.22 MiB p/s ETA 0s97.41 MiB / 130.09 MiB [----------------------------------->___________] 74.88% 50.43 MiB p/s ETA 0s104.78 MiB / 130.09 MiB [------------------------------------->________] 80.55% 50.43 MiB p/s ETA 0s111.96 MiB / 130.09 MiB [--------------------------------------->______] 86.07% 50.43 MiB p/s ETA 0s119.40 MiB / 130.09 MiB [------------------------------------------>___] 91.79% 49.54 MiB p/s ETA 0s126.71 MiB / 130.09 MiB [-------------------------------------------->_] 97.41% 49.54 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 49.54 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 47.50 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 47.50 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 47.50 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 44.43 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 44.43 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 44.43 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 41.57 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 41.57 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 41.57 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 38.88 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 38.88 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 38.88 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 36.38 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 36.38 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 36.38 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 34.03 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 34.03 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 34.03 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 31.83 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 31.83 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 31.83 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 29.78 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 29.78 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 29.78 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 27.86 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 27.86 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-------------------------------------------->] 100.00% 27.86 MiB p/s ETA 0s130.09 MiB / 130.09 MiB [-----------------------------------------------] 100.00% 15.78 MiB p/s 8.4s2026-10-27T20:53:56Z INFO [vulndb] Artifact successfully downloaded repo="mirror.gcr.io/aquasec/trivy-db:2" 2026-10-27T20:53:56Z INFO [vuln] Vulnerability scanning is enabled 2026-10-27T20:53:56Z INFO [misconfig] Misconfiguration scanning is enabled 2026-10-27T20:53:56Z INFO [checks-client] Need to update the checks bundle 2026-10-27T20:53:56Z INFO [checks-client] Downloading the checks bundle... 234.57 KiB / 234.57 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2026-10-27T20:53:57Z WARN [rego] Module will be skipped as current version of Trivy is older than minimum trivy version required - please update Trivy to use this module file_path="root/.cache/trivy/policy/content/policies/cloud/policies/aws/cloudfront/enable_logging.rego" minimum_trivy_version="0.72.0" 2026-10-27T20:53:58Z ERROR [dockerfile scanner] Failed to parse file file_path="docker/server/Dockerfile.dockerignore" err="parse dockerfile instruction: parse instruction \".git\": unknown instruction: .git" 2026-10-27T20:53:58Z INFO Number of language-specific files num=0 2026-10-27T20:53:58Z INFO Detected config files num=9 Report Summary ┌──────────────────────────────┬────────────┬─────────────────┬───────────────────┐ │ Target │ Type │ Vulnerabilities │ Misconfigurations │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ benchmarks/docker/Dockerfile │ dockerfile │ - │ 2 │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ docker/android.Dockerfile │ dockerfile │ - │ 2 │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ docker/appimage.Dockerfile │ dockerfile │ - │ 5 │ … ``` </details> 🧹 Formatting only (layout, no behaviour; the nightly lint-fix job applies these as a PR): YAML · prettier (57 files checked), BASH · shfmt (11 files checked), JSON · prettier (147 files checked) ✅ Clean: actionlint, git_diff, gitleaks, grype, jsonlint, secretlint, stylelint, trufflehog, xmllint <sub>MegaLinter on soucouyant · full logs in the Actions run · comment <code>/improve</code> for AI fix suggestions</sub>

khyretos added 1 commit

2026-10-27 21:09:05 +01:00

Character creator: trousers without a hole, a smooth collar, hair that covers the forehead

CI / dependencies (pull_request) Successful in 7s

Details

CI / std-includes (pull_request) Failing after 20s

Details

Benchmarks / benchmarks (pull_request) Failing after 2m29s

Details

CI / android (pull_request) Failing after 2m14s

Details

CI / build-test-and-coverage (pull_request) Failing after 4m47s

Details

Docs site / site (pull_request) Successful in 13s

Details

lint / megalinter (pull_request) Successful in 3m7s

Details

Windows (native) / build (pull_request) Failing after 3m30s

Details

Windows (native) / test (pull_request) Has been skipped

Details

Windows (native) / publish (pull_request) Has been skipped

Details

CI / shipping-build (pull_request) Failing after 11m55s

Details

CI / release-build (pull_request) Failing after 12m22s

Details

fcc3bf6c2a

Found by looking at the renders (Kees: "caveman"):
- Trousers were cut by bone, and spine05 carries the belly and the groin:
  a bare patch between the legs and a ragged waist. Now by height.
- Jeans, trousers and chinos stand 6 mm off the skin (they hugged like
  leggings); every top sits further out than that, or the waistband
  drew over the shirt.
- Open necklines were stairs (whole quads kept or dropped): the vertices
  on the cut's edge are slid up onto the curve (GarmentShape::neckLift,
  garmentMesh() lift, moveClothes() adds it again).
- Hair: hairstyleOnHead() takes a hairline; human heads use 1.3 rad, so
  the forehead is no longer bare to the crown. 320 guides instead of 160.
  Strand shine capped at 0.3 in the creator (white glints on thin strands).
- Tests: trousers cover the hips and groin (fails on the old cut with
  76-79 bare vertices), open necklines record their lift.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

khyretos added 1 commit

2026-10-27 21:48:31 +01:00

Tests: include <set> in test_human.cpp

CI / dependencies (pull_request) Successful in 10s

Details

CI / std-includes (pull_request) Successful in 16s

Details

CI / shipping-build (pull_request) Failing after 2m37s

Details

CI / android (pull_request) Failing after 2m11s

Details

Docs site / site (pull_request) Successful in 12s

Details

Benchmarks / benchmarks (pull_request) Failing after 5m41s

Details

lint / megalinter (pull_request) Successful in 1m16s

Details

CI / build-test-and-coverage (pull_request) Failing after 9m55s

Details

CI / release-build (pull_request) Failing after 12m8s

Details

Windows (native) / build (pull_request) Failing after 8m2s

Details

Windows (native) / test (pull_request) Has been skipped

Details

Windows (native) / publish (pull_request) Has been skipped

Details

b89aee690c

The trousers test of the last commit uses std::set; tools/ci/check_std_includes.py
(which I ran before adding that test, and not after) flags it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

khyretos referenced this pull request

2026-10-27 22:04:56 +01:00

WIP: Character creator: the Vitruvian body (CharMorph, CC0) replaces MakeHuman's mesh #139

kompas-review referenced this pull request

2026-10-27 22:05:35 +01:00

WIP: Character creator: the Vitruvian body (CharMorph, CC0) replaces MakeHuman's mesh #139

CI / dependencies (pull_request) Successful in 10s

Details

CI / std-includes (pull_request) Successful in 16s

Details

CI / shipping-build (pull_request) Failing after 2m37s

Details

CI / android (pull_request) Failing after 2m11s

Details

Docs site / site (pull_request) Successful in 12s

Details

Benchmarks / benchmarks (pull_request) Failing after 5m41s

Details

lint / megalinter (pull_request) Successful in 1m16s

Details

CI / build-test-and-coverage (pull_request) Failing after 9m55s

Details

CI / release-build (pull_request) Failing after 12m8s

Details

Windows (native) / build (pull_request) Failing after 8m2s

Details

Windows (native) / test (pull_request) Has been skipped

Details

Windows (native) / publish (pull_request) Has been skipped

Details

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin +refs/pull/137/head:khyretos/claude/creator-polish

git switch khyretos/claude/creator-polish

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.