khyretos/kk-engine
1
0
Fork 0
Code Issues 1 Pull requests 16 Projects Releases Packages Wiki Activity Actions 1

Lint fix: prettier, 1 → 0 problems in 8 files #168

Open
kompas-review wants to merge 1 commit from lint-fix/yaml_prettier into main
pull from: lint-fix/yaml_prettier
merge into: khyretos:main
Conversation 5 Commits 1 Files changed 8 +65 -36
kompas-review commented 2026-11-09 05:20:19 +01:00
Collaborator
Copy link

🧹 Lint fix · prettier (YAML)

Before: 1 problems in these 8 files. After: 0.

Files Fixed by Before After
8 files prettier 1 0

Problems left for prettier in the whole repo: about 0. The nightly job takes the next files tomorrow.

Every change was kept only because the error count of all YAML checks went down. Please read the diff before merging; kompas-review will post a review.

Nightly lint-fix job (MegaLinter + Coder, Qwen 3.5 on kireserver).

## 🧹 Lint fix · prettier (YAML) Before: **1** problems in these 8 files. After: **0**. | Files | Fixed by | Before | After | |---|---|---:|---:| | 8 files | prettier | 1 | 0 | Problems left for prettier in the whole repo: about **0**. The nightly job takes the next files tomorrow. Every change was kept only because the error count of all YAML checks went down. Please read the diff before merging; kompas-review will post a review. <sub>Nightly lint-fix job (MegaLinter + Coder, Qwen 3.5 on kireserver).</sub>
Lint fix (prettier): automatic fixes by prettier
Some checks failed
review / pr-agent PR-Agent reviewed this commit
Windows (native) / build (pull_request) Successful in 2m7s
Details
CI / android (pull_request) Successful in 3m46s
Details
CI / dependencies (pull_request) Successful in 18s
Details
CI / std-includes (pull_request) Successful in 17s
Details
Docs site / site (pull_request) Successful in 51s
Details
Benchmarks / benchmarks (pull_request) Successful in 1m44s
Details
CI / shipping-build (pull_request) Successful in 1m16s
Details
lint / megalinter (pull_request) Successful in 56s
Details
CI / release-build (pull_request) Successful in 1m41s
Details
CI / build-test-and-coverage (pull_request) Successful in 34m45s
Details
kreative-pr/review reviewed: 0 finding(s)
Details
Windows (native) / publish (pull_request) Has been cancelled
Details
Windows (native) / test (pull_request) Has been cancelled
Details
kk / all-checks Failed: Windows (native) / publish (pull_request), Windows (native) / test (pull_request)
a0403312a0
kompas-review commented 2026-11-09 05:21:05 +01:00
Author
Collaborator
Copy link

Title

Lint fix: prettier, 1 → 0 problems in 8 files

PR Type

Formatting

Description

  • Apply prettier formatting to YAML files

  • Fix indentation and inline comments

  • Standardize list and map syntax

Diagram Walkthrough

flowchart LR
  A["Source YAML"] -->|"prettier"| B["Formatted YAML"]
  B -->|"Result"| C["Zero lint errors"]

File Walkthrough
Relevant files
Formatting
8 files
overcast.yaml
Align inline comment in sky image field                                   
+1/-1     
stormy.yaml
Align inline comment in sky image field                                   
+1/-1     
sunset.yaml
Align inline comment in sky image field                                   
+1/-1     
compose.yml
Reformat volumes, command, and environment blocks               
+33/-10 
suite.yaml
Reformat env block for flying_pileup demo                               
+7/-1     
docker-compose.yml
Reformat volumes and command arrays                                           
+7/-7     
docker-compose.yml
Reformat ports, volumes, and environment entries                 
+5/-5     
pebble_hill.yaml
Convert multi-line comments to inline style                           
+10/-10 
## Title <!-- pr-agent:describe:persistent --> Lint fix: prettier, 1 → 0 problems in 8 files ___ ### **PR Type** Formatting ___ ### **Description** - Apply prettier formatting to YAML files - Fix indentation and inline comments - Standardize list and map syntax ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Source YAML"] -->|"prettier"| B["Formatted YAML"] B -->|"Result"| C["Zero lint errors"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Formatting</strong></td><td><details><summary>8 files</summary><table> <tr> <td><strong>overcast.yaml</strong><dd><code>Align inline comment in sky image field</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/assets/moods/overcast.yaml">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>stormy.yaml</strong><dd><code>Align inline comment in sky image field</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/assets/moods/stormy.yaml">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>sunset.yaml</strong><dd><code>Align inline comment in sky image field</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/assets/moods/sunset.yaml">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>compose.yml</strong><dd><code>Reformat volumes, command, and environment blocks</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/benchmarks/docker/compose.yml">+33/-10</a>&nbsp; </td> </tr> <tr> <td><strong>suite.yaml</strong><dd><code>Reformat env block for flying_pileup demo</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/benchmarks/suite.yaml">+7/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>docker-compose.yml</strong><dd><code>Reformat volumes and command arrays</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/docker-compose.yml">+7/-7</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>docker-compose.yml</strong><dd><code>Reformat ports, volumes, and environment entries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/docker/server/docker-compose.yml">+5/-5</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>pebble_hill.yaml</strong><dd><code>Convert multi-line comments to inline style</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kk-engine/src/branch/lint-fix/yaml_prettier/games/climb_race/mountains/pebble_hill.yaml">+10/-10</a>&nbsp; </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___
kompas-review commented 2026-11-09 05:21:12 +01:00
Author
Collaborator
Copy link

PR Reviewer Guide 🔍

(Review updated until commit a0403312a0)

Here are some key observations to aid the review process:

🔒 No security concerns identified
⚡ No major issues detected
## PR Reviewer Guide 🔍 <!-- pr-agent:review:full --> #### (Review updated until commit https://git.kreative-kompas.com/khyretos/kk-engine/commit/a0403312a0d272d062b1ff5eab4558c1a51fe00b) Here are some key observations to aid the review process: <table> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>No major issues detected</strong></td></tr> </table>
forgejo-actions commented 2026-11-09 12:14:18 +01:00
Copy link

🧹 Lint report · ❌ 38 problems in 6 checks · 🧹 2 formatting checks to tidy

Nothing here blocks the merge (report only).

Check Errors Warnings Files
❌ MARKDOWN · markdownlint 24 0 254
❌ CPP · cppcheck 9 0 942
❌ YAML · yamllint 2 0 57
❌ BASH · shellcheck 1 0 13
❌ DOCKERFILE · hadolint 1 0 9
❌ REPOSITORY · trivy 1 0 –
MARKDOWN · markdownlint: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/markdown_markdownlint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
docs/ANDROID.md:87 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:128 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:136 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:149 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:163 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ANDROID.md:186 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/ASSETS.md:155 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
docs/HISTORY.md:21 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: " Kreative Kompas Engine (KKE)"]
docs/HISTORY.md:520 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:727 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:734 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:2031 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/HISTORY.md:2090 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/MODDING.md:13 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/NETWORKING.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PLATFORMS.md:48 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PROCEDURAL_ANIMATION.md:36 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
docs/PROCEDURAL_ANIMATION.md:284 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
games/racing/README.md:34 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
games/racing/README.md:76:91 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
games/racing/README.md:77:89 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
…
CPP · cppcheck: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/cpp_cppcheck/
-----------------------------------------------
✅ [SUCCESS] benchmarks/kke_bench/main.cpp
✅ [SUCCESS] benchmarks/kke_benchmark/main.cpp
✅ [SUCCESS] engine/include/engine/Buffer.h
✅ [SUCCESS] engine/include/engine/Mesh.h
✅ [SUCCESS] engine/include/engine/Pipeline.h
✅ [SUCCESS] engine/include/engine/Renderer.h
✅ [SUCCESS] engine/include/engine/SwapChain.h
✅ [SUCCESS] engine/include/engine/VulkanCheck.h
✅ [SUCCESS] engine/include/engine/VulkanDevice.h
✅ [SUCCESS] engine/include/engine/Window.h
✅ [SUCCESS] engine/include/kke/AnimEvents.h
✅ [SUCCESS] engine/include/kke/AnimRig.h
✅ [SUCCESS] engine/include/kke/Animator.h
✅ [SUCCESS] engine/include/kke/Application.h
✅ [SUCCESS] engine/include/kke/AssetCatalog.h
✅ [SUCCESS] engine/include/kke/AudioMixer.h
✅ [SUCCESS] engine/include/kke/AutoRig.h
✅ [SUCCESS] engine/include/kke/BenchRecorder.h
✅ [SUCCESS] engine/include/kke/BenchmarkReport.h
✅ [SUCCESS] engine/include/kke/Bloom.h
✅ [SUCCESS] engine/include/kke/BodyShape.h
✅ [SUCCESS] engine/include/kke/BreakGraph.h
✅ [SUCCESS] engine/include/kke/Breakables.h
…
YAML · yamllint: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/yaml_yamllint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
games/goblin_horde/data/heroes.yml
  53:11     error    too many spaces after colon  (colons)
  63:11     error    too many spaces after colon  (colons)
BASH · shellcheck: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/bash_shellcheck/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
In tools/packaging/package.sh line 130:
	done < <(find "$stage" "$stage/benchmark" -maxdepth 1 -type f \( -name "*$exe" -o -name '*.dll' \) $([ -z "$exe" ] && echo "-perm -u+x") -print0)
                                                                                                           ^-- SC2046 (warning): Quote this to prevent word splitting.
For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
DOCKERFILE · hadolint: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/dockerfile_hadolint/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
docker/android.Dockerfile:19 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:38 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.
docker/appimage.Dockerfile:51 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:57 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:63 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:63 DL3003 warning: Use WORKDIR to switch to a directory
docker/appimage.Dockerfile:73 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/appimage.Dockerfile:73 DL3003 warning: Use WORKDIR to switch to a directory
docker/ci.Dockerfile:42 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/ci.Dockerfile:56 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/server/Dockerfile:22 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
docker/vm.Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
docker/vm.Dockerfile:29 DL3003 warning: Use WORKDIR to switch to a directory
docker/vm.Dockerfile:29 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
website/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
REPOSITORY · trivy: first lines of the output 
See documentation on https://megalinter.io/9.4.0/descriptors/repository_trivy/
-----------------------------------------------
❌ [ERROR] for workspace /workspace/khyretos/kk-engine
Linter raw log:
2026-11-09T11:13:29Z	INFO	[vulndb] Need to update DB
2026-11-09T11:13:29Z	INFO	[vulndb] Downloading vulnerability DB...
2026-11-09T11:13:29Z	INFO	[vulndb] Downloading artifact...	repo="mirror.gcr.io/aquasec/trivy-db:2"
10.11 MiB / 131.09 MiB [---->________________________________________________________] 7.71% ? p/s ?16.17 MiB / 131.09 MiB [------->____________________________________________________] 12.34% ? p/s ?18.36 MiB / 131.09 MiB [-------->___________________________________________________] 14.00% ? p/s ?23.50 MiB / 131.09 MiB [-------->______________________________________] 17.93% 22.30 MiB p/s ETA 4s27.12 MiB / 131.09 MiB [--------->_____________________________________] 20.69% 22.30 MiB p/s ETA 4s30.12 MiB / 131.09 MiB [---------->____________________________________] 22.98% 22.30 MiB p/s ETA 4s33.08 MiB / 131.09 MiB [----------->___________________________________] 25.23% 21.89 MiB p/s ETA 4s35.54 MiB / 131.09 MiB [------------>__________________________________] 27.11% 21.89 MiB p/s ETA 4s38.09 MiB / 131.09 MiB [------------->_________________________________] 29.06% 21.89 MiB p/s ETA 4s41.10 MiB / 131.09 MiB [-------------->________________________________] 31.35% 21.34 MiB p/s ETA 4s46.12 MiB / 131.09 MiB [---------------->______________________________] 35.18% 21.34 MiB p/s ETA 3s50.30 MiB / 131.09 MiB [------------------>____________________________] 38.37% 21.34 MiB p/s ETA 3s53.93 MiB / 131.09 MiB [------------------->___________________________] 41.14% 21.34 MiB p/s ETA 3s57.88 MiB / 131.09 MiB [-------------------->__________________________] 44.15% 21.34 MiB p/s ETA 3s61.82 MiB / 131.09 MiB [---------------------->________________________] 47.15% 21.34 MiB p/s ETA 3s67.13 MiB / 131.09 MiB [------------------------>______________________] 51.20% 21.39 MiB p/s ETA 2s82.05 MiB / 131.09 MiB [----------------------------->_________________] 62.59% 21.39 MiB p/s ETA 2s104.23 MiB / 131.09 MiB [------------------------------------>_________] 79.51% 21.39 MiB p/s ETA 1s126.35 MiB / 131.09 MiB [-------------------------------------------->_] 96.38% 26.37 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 26.37 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 26.37 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 25.18 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 25.18 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 25.18 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 23.56 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 23.56 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 23.56 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 22.04 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 22.04 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-----------------------------------------------] 100.00% 23.34 MiB p/s 5.8s2026-11-09T11:13:35Z	INFO	[vulndb] Artifact successfully downloaded	repo="mirror.gcr.io/aquasec/trivy-db:2"
2026-11-09T11:13:35Z	INFO	[vuln] Vulnerability scanning is enabled
2026-11-09T11:13:35Z	INFO	[misconfig] Misconfiguration scanning is enabled
2026-11-09T11:13:35Z	INFO	[checks-client] Need to update the checks bundle
2026-11-09T11:13:35Z	INFO	[checks-client] Downloading the checks bundle...
234.57 KiB / 234.57 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2026-11-09T11:13:36Z	WARN	[rego] Module will be skipped as current version of Trivy is older than minimum trivy version required - please update Trivy to use this module	file_path="root/.cache/trivy/policy/content/policies/cloud/policies/aws/cloudfront/enable_logging.rego" minimum_trivy_version="0.72.0"
2026-11-09T11:13:36Z	ERROR	[dockerfile scanner] Failed to parse file	file_path="docker/server/Dockerfile.dockerignore" err="parse dockerfile instruction: parse instruction \".git\": unknown instruction: .git"
2026-11-09T11:13:36Z	INFO	Number of language-specific files	num=0
2026-11-09T11:13:36Z	INFO	Detected config files	num=9
Report Summary
┌──────────────────────────────┬────────────┬─────────────────┬───────────────────┐
│            Target            │    Type    │ Vulnerabilities │ Misconfigurations │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ benchmarks/docker/Dockerfile │ dockerfile │        -        │         2         │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ docker/android.Dockerfile    │ dockerfile │        -        │         2         │
├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤
│ docker/appimage.Dockerfile   │ dockerfile │        -        │         5         │
…

🧹 Formatting only (layout, no behaviour; the nightly lint-fix job applies these as a PR): YAML · prettier (57 files checked), BASH · shfmt (13 files checked)

✅ Clean: actionlint, git_diff, gitleaks, grype, jsonlint, prettier, secretlint, stylelint, trufflehog, xmllint

MegaLinter on soucouyant · full logs in the Actions run · comment /improve for AI fix suggestions

<!-- kk-lint --> ## 🧹 Lint report · ❌ 38 problems in 6 checks · 🧹 2 formatting checks to tidy Nothing here blocks the merge (report only). | | Check | Errors | Warnings | Files | |---|---|---:|---:|---:| | ❌ | MARKDOWN · markdownlint | 24 | 0 | 254 | | ❌ | CPP · cppcheck | 9 | 0 | 942 | | ❌ | YAML · yamllint | 2 | 0 | 57 | | ❌ | BASH · shellcheck | 1 | 0 | 13 | | ❌ | DOCKERFILE · hadolint | 1 | 0 | 9 | | ❌ | REPOSITORY · trivy | 1 | 0 | – | <details><summary>MARKDOWN · markdownlint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/markdown_markdownlint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: docs/ANDROID.md:87 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:128 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:136 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:149 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:163 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ANDROID.md:186 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/ASSETS.md:155 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented] docs/HISTORY.md:21 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: " Kreative Kompas Engine (KKE)"] docs/HISTORY.md:520 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:727 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:734 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:2031 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/HISTORY.md:2090 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/MODDING.md:13 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/NETWORKING.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PLATFORMS.md:48 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PROCEDURAL_ANIMATION.md:36 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] docs/PROCEDURAL_ANIMATION.md:284 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] games/racing/README.md:34 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] games/racing/README.md:76:91 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] games/racing/README.md:77:89 error MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data] … ``` </details> <details><summary>CPP · cppcheck: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/cpp_cppcheck/ ----------------------------------------------- ✅ [SUCCESS] benchmarks/kke_bench/main.cpp ✅ [SUCCESS] benchmarks/kke_benchmark/main.cpp ✅ [SUCCESS] engine/include/engine/Buffer.h ✅ [SUCCESS] engine/include/engine/Mesh.h ✅ [SUCCESS] engine/include/engine/Pipeline.h ✅ [SUCCESS] engine/include/engine/Renderer.h ✅ [SUCCESS] engine/include/engine/SwapChain.h ✅ [SUCCESS] engine/include/engine/VulkanCheck.h ✅ [SUCCESS] engine/include/engine/VulkanDevice.h ✅ [SUCCESS] engine/include/engine/Window.h ✅ [SUCCESS] engine/include/kke/AnimEvents.h ✅ [SUCCESS] engine/include/kke/AnimRig.h ✅ [SUCCESS] engine/include/kke/Animator.h ✅ [SUCCESS] engine/include/kke/Application.h ✅ [SUCCESS] engine/include/kke/AssetCatalog.h ✅ [SUCCESS] engine/include/kke/AudioMixer.h ✅ [SUCCESS] engine/include/kke/AutoRig.h ✅ [SUCCESS] engine/include/kke/BenchRecorder.h ✅ [SUCCESS] engine/include/kke/BenchmarkReport.h ✅ [SUCCESS] engine/include/kke/Bloom.h ✅ [SUCCESS] engine/include/kke/BodyShape.h ✅ [SUCCESS] engine/include/kke/BreakGraph.h ✅ [SUCCESS] engine/include/kke/Breakables.h … ``` </details> <details><summary>YAML · yamllint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/yaml_yamllint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: games/goblin_horde/data/heroes.yml 53:11 error too many spaces after colon (colons) 63:11 error too many spaces after colon (colons) ``` </details> <details><summary>BASH · shellcheck: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/bash_shellcheck/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: In tools/packaging/package.sh line 130: done < <(find "$stage" "$stage/benchmark" -maxdepth 1 -type f \( -name "*$exe" -o -name '*.dll' \) $([ -z "$exe" ] && echo "-perm -u+x") -print0) ^-- SC2046 (warning): Quote this to prevent word splitting. For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... ``` </details> <details><summary>DOCKERFILE · hadolint: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/dockerfile_hadolint/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: docker/android.Dockerfile:19 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:38 SC2016 info: Expressions don't expand in single quotes, use double quotes for that. docker/appimage.Dockerfile:51 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:57 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:63 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:63 DL3003 warning: Use WORKDIR to switch to a directory docker/appimage.Dockerfile:73 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/appimage.Dockerfile:73 DL3003 warning: Use WORKDIR to switch to a directory docker/ci.Dockerfile:42 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/ci.Dockerfile:56 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/server/Dockerfile:22 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check docker/vm.Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting. docker/vm.Dockerfile:29 DL3003 warning: Use WORKDIR to switch to a directory docker/vm.Dockerfile:29 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check website/Dockerfile:9 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check ``` </details> <details><summary>REPOSITORY · trivy: first lines of the output</summary> ```text See documentation on https://megalinter.io/9.4.0/descriptors/repository_trivy/ ----------------------------------------------- ❌ [ERROR] for workspace /workspace/khyretos/kk-engine Linter raw log: 2026-11-09T11:13:29Z INFO [vulndb] Need to update DB 2026-11-09T11:13:29Z INFO [vulndb] Downloading vulnerability DB... 2026-11-09T11:13:29Z INFO [vulndb] Downloading artifact... repo="mirror.gcr.io/aquasec/trivy-db:2" 10.11 MiB / 131.09 MiB [---->________________________________________________________] 7.71% ? p/s ?16.17 MiB / 131.09 MiB [------->____________________________________________________] 12.34% ? p/s ?18.36 MiB / 131.09 MiB [-------->___________________________________________________] 14.00% ? p/s ?23.50 MiB / 131.09 MiB [-------->______________________________________] 17.93% 22.30 MiB p/s ETA 4s27.12 MiB / 131.09 MiB [--------->_____________________________________] 20.69% 22.30 MiB p/s ETA 4s30.12 MiB / 131.09 MiB [---------->____________________________________] 22.98% 22.30 MiB p/s ETA 4s33.08 MiB / 131.09 MiB [----------->___________________________________] 25.23% 21.89 MiB p/s ETA 4s35.54 MiB / 131.09 MiB [------------>__________________________________] 27.11% 21.89 MiB p/s ETA 4s38.09 MiB / 131.09 MiB [------------->_________________________________] 29.06% 21.89 MiB p/s ETA 4s41.10 MiB / 131.09 MiB [-------------->________________________________] 31.35% 21.34 MiB p/s ETA 4s46.12 MiB / 131.09 MiB [---------------->______________________________] 35.18% 21.34 MiB p/s ETA 3s50.30 MiB / 131.09 MiB [------------------>____________________________] 38.37% 21.34 MiB p/s ETA 3s53.93 MiB / 131.09 MiB [------------------->___________________________] 41.14% 21.34 MiB p/s ETA 3s57.88 MiB / 131.09 MiB [-------------------->__________________________] 44.15% 21.34 MiB p/s ETA 3s61.82 MiB / 131.09 MiB [---------------------->________________________] 47.15% 21.34 MiB p/s ETA 3s67.13 MiB / 131.09 MiB [------------------------>______________________] 51.20% 21.39 MiB p/s ETA 2s82.05 MiB / 131.09 MiB [----------------------------->_________________] 62.59% 21.39 MiB p/s ETA 2s104.23 MiB / 131.09 MiB [------------------------------------>_________] 79.51% 21.39 MiB p/s ETA 1s126.35 MiB / 131.09 MiB [-------------------------------------------->_] 96.38% 26.37 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 26.37 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 26.37 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 25.18 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 25.18 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 25.18 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 23.56 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 23.56 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 23.56 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 22.04 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-------------------------------------------->] 100.00% 22.04 MiB p/s ETA 0s131.09 MiB / 131.09 MiB [-----------------------------------------------] 100.00% 23.34 MiB p/s 5.8s2026-11-09T11:13:35Z INFO [vulndb] Artifact successfully downloaded repo="mirror.gcr.io/aquasec/trivy-db:2" 2026-11-09T11:13:35Z INFO [vuln] Vulnerability scanning is enabled 2026-11-09T11:13:35Z INFO [misconfig] Misconfiguration scanning is enabled 2026-11-09T11:13:35Z INFO [checks-client] Need to update the checks bundle 2026-11-09T11:13:35Z INFO [checks-client] Downloading the checks bundle... 234.57 KiB / 234.57 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2026-11-09T11:13:36Z WARN [rego] Module will be skipped as current version of Trivy is older than minimum trivy version required - please update Trivy to use this module file_path="root/.cache/trivy/policy/content/policies/cloud/policies/aws/cloudfront/enable_logging.rego" minimum_trivy_version="0.72.0" 2026-11-09T11:13:36Z ERROR [dockerfile scanner] Failed to parse file file_path="docker/server/Dockerfile.dockerignore" err="parse dockerfile instruction: parse instruction \".git\": unknown instruction: .git" 2026-11-09T11:13:36Z INFO Number of language-specific files num=0 2026-11-09T11:13:36Z INFO Detected config files num=9 Report Summary ┌──────────────────────────────┬────────────┬─────────────────┬───────────────────┐ │ Target │ Type │ Vulnerabilities │ Misconfigurations │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ benchmarks/docker/Dockerfile │ dockerfile │ - │ 2 │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ docker/android.Dockerfile │ dockerfile │ - │ 2 │ ├──────────────────────────────┼────────────┼─────────────────┼───────────────────┤ │ docker/appimage.Dockerfile │ dockerfile │ - │ 5 │ … ``` </details> 🧹 Formatting only (layout, no behaviour; the nightly lint-fix job applies these as a PR): YAML · prettier (57 files checked), BASH · shfmt (13 files checked) ✅ Clean: actionlint, git_diff, gitleaks, grype, jsonlint, prettier, secretlint, stylelint, trufflehog, xmllint <sub>MegaLinter on soucouyant · full logs in the Actions run · comment <code>/improve</code> for AI fix suggestions</sub>
kompas-review commented 2026-11-10 03:39:41 +01:00
Author
Collaborator
Copy link

/review

/review
kompas-review commented 2026-11-10 04:40:04 +01:00
Author
Collaborator
Copy link

/review

/review
Some checks failed
review / pr-agent PR-Agent reviewed this commit
Required
Windows (native) / build (pull_request) Successful in 2m7s
Required
Details
CI / android (pull_request) Successful in 3m46s
Required
Details
CI / dependencies (pull_request) Successful in 18s
Required
Details
CI / std-includes (pull_request) Successful in 17s
Required
Details
Docs site / site (pull_request) Successful in 51s
Required
Details
Benchmarks / benchmarks (pull_request) Successful in 1m44s
Required
Details
CI / shipping-build (pull_request) Successful in 1m16s
Required
Details
lint / megalinter (pull_request) Successful in 56s
Required
Details
CI / release-build (pull_request) Successful in 1m41s
Required
Details
CI / build-test-and-coverage (pull_request) Successful in 34m45s
Required
Details
kreative-pr/review reviewed: 0 finding(s)
Details
Windows (native) / publish (pull_request) Has been cancelled
Details
Windows (native) / test (pull_request) Has been cancelled
Required
Details
kk / all-checks Failed: Windows (native) / publish (pull_request), Windows (native) / test (pull_request)
Required
Some required checks were not successful.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin lint-fix/yaml_prettier:lint-fix/yaml_prettier
git switch lint-fix/yaml_prettier
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
deps
Renovate: patch/minor/digest update

  
deps-major
Renovate: major or 0.x minor update

  
hold
kompas-review waits until Kees replies merge

  
security
Renovate: fixes a known vulnerability

No labels
deps
deps-major
hold
security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
khyretos/kk-engine!168
No description provided.