STEP-ICON, ACTIVITY-CARD, DESKTOP-DROP: plain step icons, Activity cards like facts, drop files into the desktop app #320
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "khyretos/plain-step-icons"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Three small UI fixes.
ago(), which subtracted the wrong way round and said "just now" for every step.dropevent.dragDropEnabled: falseon the main window lets the web UI's drop-anywhere code (#309) get it, as in the browser.Tests: tsc clean; Playwright activity, costs, pane-layout, factcards, ux-round2 specs pass (42), plus a new Activity card test.
Not verified: the desktop fix needs a rebuilt desktop app (the config is read at build time); it was not run here.
Title
STEP-ICON, ACTIVITY-CARD, DESKTOP-DROP: plain step icons, Activity cards like facts, drop files into the desktop app
User description
Three small UI fixes.
ago(), which subtracted the wrong way round and said "just now" for every step.dropevent.dragDropEnabled: falseon the main window lets the web UI's drop-anywhere code (#309) get it, as in the browser.Tests: tsc clean; Playwright activity, costs, pane-layout, factcards, ux-round2 specs pass (42), plus a new Activity card test.
Not verified: the desktop fix needs a rebuilt desktop app (the config is read at build time); it was not run here.
PR Type
Enhancement, Bug fix
Description
Redesigns Activity cards to match Fact cards with collapsible bodies.
Fixes
ago()calculation to show correct relative time for steps.Removes background squares from step kind icons in conversation.
Disables Tauri native file-drop to enable web UI drop handling.
Diagram Walkthrough
File Walkthrough
4 files
Imports openActs function for activity state managementRefactors Activity card layout and fixes ago() time logicExports KIND_ICON and removes background square from iconsStyles plain step icons and defines new Activity card layout3 files
Adds comprehensive test for new Activity card behaviorUpdates selector to target new act-step classVerifies icon colors and absence of background squares1 files
Disables native drag-drop to allow web UI handlingPR Reviewer Guide 🔍
(Review updated until commit
009e7feec5)Here are some key observations to aid the review process:
🧹 Lint report · ✅ all 25 checks clean
Errors below fail this check.
✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint
MegaLinter on soucouyant · full logs in the Actions run · comment
/improvefor AI fix suggestions/review