STEP-ICON, ACTIVITY-CARD, DESKTOP-DROP: plain step icons, Activity cards like facts, drop files into the desktop app #320

Merged
kompas-review merged 3 commits from khyretos/plain-step-icons into main 2026-10-28 20:09:11 +01:00
Owner

Three small UI fixes.

  • STEP-ICON: a step's kind icon is a plain glyph in the card colour, with no square behind it (the chat cards).
  • ACTIVITY-CARD: an Activity step is a card like a fact: header (icon, what it did, state), dark body (first output line, the whole output when opened), footer (kind, computer, when). It opens and closes and stays open across redraws. Also fixes ago(), which subtracted the wrong way round and said "just now" for every step.
  • DESKTOP-DROP: the desktop app (Tauri, Linux) did not attach dropped files: Tauri's native file-drop handler swallowed the page's drop event. dragDropEnabled: false on the main window lets the web UI's drop-anywhere code (#309) get it, as in the browser.

Tests: tsc clean; Playwright activity, costs, pane-layout, factcards, ux-round2 specs pass (42), plus a new Activity card test.
Not verified: the desktop fix needs a rebuilt desktop app (the config is read at build time); it was not run here.

Three small UI fixes. - **STEP-ICON**: a step's kind icon is a plain glyph in the card colour, with no square behind it (the chat cards). - **ACTIVITY-CARD**: an Activity step is a card like a fact: header (icon, what it did, state), dark body (first output line, the whole output when opened), footer (kind, computer, when). It opens and closes and stays open across redraws. Also fixes `ago()`, which subtracted the wrong way round and said "just now" for every step. - **DESKTOP-DROP**: the desktop app (Tauri, Linux) did not attach dropped files: Tauri's native file-drop handler swallowed the page's `drop` event. `dragDropEnabled: false` on the main window lets the web UI's drop-anywhere code (#309) get it, as in the browser. Tests: tsc clean; Playwright activity, costs, pane-layout, factcards, ux-round2 specs pass (42), plus a new Activity card test. Not verified: the desktop fix needs a rebuilt desktop app (the config is read at build time); it was not run here.
DESKTOP-DROP: turn off Tauri native file-drop so the page gets the drop event (drag a file into the chat works in the desktop app)
All checks were successful
build / skills (pull_request) Successful in 10s
build / web (pull_request) Successful in 20s
build / runner (pull_request) Successful in 8s
build / runner-windows (pull_request) Successful in 9s
fresh-install / fresh-install (pull_request) Successful in 10s
lint / megalinter (pull_request) Successful in 53s
review-gate / sweep (pull_request) Successful in 3s
build / server (pull_request) Successful in 4m23s
desktop / linux (pull_request) Successful in 8m58s
review-gate / gate review findings are all handled
build / web-live (pull_request) Successful in 27m37s
kk / all-checks All 10 checks passed
009e7feec5
kompas-review scheduled this pull request to auto merge when all checks succeed 2026-10-28 19:41:30 +01:00
Collaborator

Title

STEP-ICON, ACTIVITY-CARD, DESKTOP-DROP: plain step icons, Activity cards like facts, drop files into the desktop app


User description

Three small UI fixes.

  • STEP-ICON: a step's kind icon is a plain glyph in the card colour, with no square behind it (the chat cards).
  • ACTIVITY-CARD: an Activity step is a card like a fact: header (icon, what it did, state), dark body (first output line, the whole output when opened), footer (kind, computer, when). It opens and closes and stays open across redraws. Also fixes ago(), which subtracted the wrong way round and said "just now" for every step.
  • DESKTOP-DROP: the desktop app (Tauri, Linux) did not attach dropped files: Tauri's native file-drop handler swallowed the page's drop event. dragDropEnabled: false on the main window lets the web UI's drop-anywhere code (#309) get it, as in the browser.

Tests: tsc clean; Playwright activity, costs, pane-layout, factcards, ux-round2 specs pass (42), plus a new Activity card test.
Not verified: the desktop fix needs a rebuilt desktop app (the config is read at build time); it was not run here.


PR Type

Enhancement, Bug fix


Description

  • Redesigns Activity cards to match Fact cards with collapsible bodies.

  • Fixes ago() calculation to show correct relative time for steps.

  • Removes background squares from step kind icons in conversation.

  • Disables Tauri native file-drop to enable web UI drop handling.


Diagram Walkthrough

flowchart LR
  A["Activity Card"] -->|"New Layout"| B["Fact Card Style"]
  C["Step Icon"] -->|"Visual Change"| D["Plain Glyph"]
  E["Desktop App"] -.->|"Config Fix"| F["Web Drop Handler"]

File Walkthrough

Relevant files
Enhancement
4 files
main.ts
Imports openActs function for activity state management   
+11/-1   
activity.ts
Refactors Activity card layout and fixes ago() time logic
+44/-23 
conversation.ts
Exports KIND_ICON and removes background square from icons
+3/-3     
styles.css
Styles plain step icons and defines new Activity card layout
+28/-2   
Tests
3 files
activity.spec.ts
Adds comprehensive test for new Activity card behavior     
+26/-0   
costs.spec.ts
Updates selector to target new act-step class                       
+1/-1     
ux-round2.spec.ts
Verifies icon colors and absence of background squares     
+3/-1     
Configuration changes
1 files
tauri.conf.json
Disables native drag-drop to allow web UI handling             
+2/-1     

## Title STEP-ICON, ACTIVITY-CARD, DESKTOP-DROP: plain step icons, Activity cards like facts, drop files into the desktop app ___ ### **User description** Three small UI fixes. - **STEP-ICON**: a step's kind icon is a plain glyph in the card colour, with no square behind it (the chat cards). - **ACTIVITY-CARD**: an Activity step is a card like a fact: header (icon, what it did, state), dark body (first output line, the whole output when opened), footer (kind, computer, when). It opens and closes and stays open across redraws. Also fixes `ago()`, which subtracted the wrong way round and said "just now" for every step. - **DESKTOP-DROP**: the desktop app (Tauri, Linux) did not attach dropped files: Tauri's native file-drop handler swallowed the page's `drop` event. `dragDropEnabled: false` on the main window lets the web UI's drop-anywhere code (#309) get it, as in the browser. Tests: tsc clean; Playwright activity, costs, pane-layout, factcards, ux-round2 specs pass (42), plus a new Activity card test. Not verified: the desktop fix needs a rebuilt desktop app (the config is read at build time); it was not run here. ___ ### **PR Type** Enhancement, Bug fix ___ ### **Description** - Redesigns Activity cards to match Fact cards with collapsible bodies. - Fixes `ago()` calculation to show correct relative time for steps. - Removes background squares from step kind icons in conversation. - Disables Tauri native file-drop to enable web UI drop handling. ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Activity Card"] -->|"New Layout"| B["Fact Card Style"] C["Step Icon"] -->|"Visual Change"| D["Plain Glyph"] E["Desktop App"] -.->|"Config Fix"| F["Web Drop Handler"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>4 files</summary><table> <tr> <td><strong>main.ts</strong><dd><code>Imports openActs function for activity state management</code>&nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/src/main.ts">+11/-1</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>activity.ts</strong><dd><code>Refactors Activity card layout and fixes ago() time logic</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/src/views/activity.ts">+44/-23</a>&nbsp; </td> </tr> <tr> <td><strong>conversation.ts</strong><dd><code>Exports KIND_ICON and removes background square from icons</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/src/views/conversation.ts">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>styles.css</strong><dd><code>Styles plain step icons and defines new Activity card layout</code></dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/src/styles.css">+28/-2</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>3 files</summary><table> <tr> <td><strong>activity.spec.ts</strong><dd><code>Adds comprehensive test for new Activity card behavior</code>&nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/tests/activity.spec.ts">+26/-0</a>&nbsp; &nbsp; </td> </tr> <tr> <td><strong>costs.spec.ts</strong><dd><code>Updates selector to target new act-step class</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/tests/costs.spec.ts">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>ux-round2.spec.ts</strong><dd><code>Verifies icon colors and absence of background squares</code>&nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/web/tests/ux-round2.spec.ts">+3/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>tauri.conf.json</strong><dd><code>Disables native drag-drop to allow web UI handling</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/khyretos/plain-step-icons/desktop/src-tauri/tauri.conf.json">+2/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___
Collaborator

PR Reviewer Guide 🔍

(Review updated until commit 009e7feec5)

Here are some key observations to aid the review process:

🔒 No security concerns identified
⚡ No major issues detected
## PR Reviewer Guide 🔍 <!-- pr-agent:review:full --> #### (Review updated until commit https://git.kreative-kompas.com/khyretos/kreative-kompanion/commit/009e7feec5b23fff2760581ff16f789062ba8355) Here are some key observations to aid the review process: <table> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>No major issues detected</strong></td></tr> </table>

🧹 Lint report · ✅ all 25 checks clean

Errors below fail this check.

✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint

MegaLinter on soucouyant · full logs in the Actions run · comment /improve for AI fix suggestions

<!-- kk-lint --> ## 🧹 Lint report · ✅ all 25 checks clean Errors below fail this check. ✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint <sub>MegaLinter on soucouyant · full logs in the Actions run · comment <code>/improve</code> for AI fix suggestions</sub>
Collaborator

/review

/review
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
khyretos/kreative-kompanion!320
No description provided.