deps: Rust 0.x majors in one port (sqlx 0.9, argon2 0.6, rand 0.10, RustCrypto, reqwest 0.13, ureq 3, …) #361

Merged
kompas-review merged 3 commits from deps/rust-majors-2026-11-09 into main 2026-11-09 13:49:30 +01:00
Owner

Requested by Kees

The Rust 0.x major updates in one port (they break the build one by one, so they land together).

PR crate(s) what changed
#347 sqlx 0.9 34 format!-built queries through sqlx::AssertSqlSafe (each checked: column lists, fixed table/column names, joined i64 ids, ?-placeholder filters, test fixtures; no user text in the SQL), QueryAs/SqliteArguments lifetime
#342 libsqlite3-sys 0.37: sqlx 0.9 links >=0.30.1, <0.38; held there in renovate.json
#338 argon2 0.6 hash_password makes its own random salt (no more SaltString)
#344 rand 0.10 Rng is the old RngCore
#346 #341 #340 #343 #337 sha2 0.11, hmac 0.13, hkdf 0.13, p256 0.14, aes-gcm 0.11 KeyInit for new_from_slice, ToSec1Point
#345 reqwest 0.13 rustls-no-provider (ring stays through lettre, so the Alpine build needs nothing new) + query
#339 #348/#359 #349 base64 0.23, toml 1, tower-http 0.7 no code changes
#360 ureq 3 (runner, desktop) runner: one agent() helper; pairing and kompanion-runner ask still show Kompanion's error text (non-2xx answers are read, not turned into errors); the stats loop still exits on 401
#350 windows-sys 0.61 no code changes

Checked on soucouyant in a throwaway rust:1 container: cargo clippy --all-targets for server, runner and machine-stats; cargo check --target x86_64-pc-windows-gnu for runner and machine-stats; cargo check for the desktop (Tauri) app. CI runs the tests.

Once this merges, Renovate closes the PRs above.

🤖 Generated with Claude Code

<!-- claude-projects-attribution: {"github_login":"Khyretos"} --> _Requested by **Kees**_ The Rust 0.x major updates in one port (they break the build one by one, so they land together). | PR | crate(s) | what changed | |---|---|---| | #347 | sqlx 0.9 | 34 `format!`-built queries through `sqlx::AssertSqlSafe` (each checked: column lists, fixed table/column names, joined `i64` ids, `?`-placeholder filters, test fixtures; no user text in the SQL), `QueryAs`/`SqliteArguments` lifetime | | #342 | libsqlite3-sys | **0.37**: sqlx 0.9 links `>=0.30.1, <0.38`; held there in `renovate.json` | | #338 | argon2 0.6 | `hash_password` makes its own random salt (no more `SaltString`) | | #344 | rand 0.10 | `Rng` is the old `RngCore` | | #346 #341 #340 #343 #337 | sha2 0.11, hmac 0.13, hkdf 0.13, p256 0.14, aes-gcm 0.11 | `KeyInit` for `new_from_slice`, `ToSec1Point` | | #345 | reqwest 0.13 | `rustls-no-provider` (ring stays through lettre, so the Alpine build needs nothing new) + `query` | | #339 #348/#359 #349 | base64 0.23, toml 1, tower-http 0.7 | no code changes | | #360 | ureq 3 (runner, desktop) | runner: one `agent()` helper; pairing and `kompanion-runner ask` still show Kompanion's error text (non-2xx answers are read, not turned into errors); the stats loop still exits on 401 | | #350 | windows-sys 0.61 | no code changes | Checked on soucouyant in a throwaway `rust:1` container: `cargo clippy --all-targets` for server, runner and machine-stats; `cargo check --target x86_64-pc-windows-gnu` for runner and machine-stats; `cargo check` for the desktop (Tauri) app. CI runs the tests. Once this merges, Renovate closes the PRs above. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
deps: the Rust 0.x majors in one port
Some checks failed
kreative-pr/review reviewed: 0 finding(s)
review-gate / sweep (pull_request) Has been cancelled
build / server (pull_request) Failing after 13m4s
build / skills (pull_request) Successful in 26s
kk / all-checks Failed: build / server (pull_request)
build / web (pull_request) Successful in 32s
build / runner-windows (pull_request) Successful in 1m48s
build / runner (pull_request) Successful in 3m3s
lint / megalinter (pull_request) Has been cancelled
build / web-live (pull_request) Has been cancelled
fresh-install / fresh-install (pull_request) Has been cancelled
desktop / linux (pull_request) Has been cancelled
8b610b2cc9
server: argon2 0.6, base64 0.23, rand 0.10, sha2 0.11, hmac 0.13, hkdf 0.13,
p256 0.14, aes-gcm 0.11, sqlx 0.9 (+ libsqlite3-sys 0.37), reqwest 0.13,
toml 1, tower-http 0.7. runner: sha2 0.11, toml 1, ureq 3. desktop: ureq 3.
machine-stats: windows-sys 0.61.

- sqlx 0.9: the format!-built queries (column lists, fixed table and column
  names, i64 id lists, ?-placeholder filters; never user text) go through
  sqlx::AssertSqlSafe; QueryAs/SqliteArguments lost a lifetime
- argon2 0.6: hash_password draws the salt itself
- rand 0.10: Rng is the old RngCore
- RustCrypto: KeyInit for Hmac::new_from_slice, ToSec1Point
- reqwest 0.13: rustls-no-provider (ring stays via lettre) + query
- ureq 3 (runner): one agent() helper with a global timeout; pairing and
  'ask' keep showing Kompanion's own error text by reading non-2xx
  answers themselves (http_status_as_error off), the stats loop still
  stops on 401 (Error::StatusCode)
- renovate.json: libsqlite3-sys stays below 0.38 until sqlx allows more

Checked on soucouyant in a throwaway rust:1 container: clippy --all-targets
for server, runner and machine-stats, cargo check for the Windows target
(runner, machine-stats) and for the desktop app.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator

Title

deps: Rust 0.x majors in one port (sqlx 0.9, argon2 0.6, rand 0.10, RustCrypto, reqwest 0.13, ureq 3, …)


PR Type

Bug fix, Enhancement, Documentation


Description

  • Port Rust crates to 0.x majors across server and runner.

  • Harden SQL queries with sqlx::AssertSqlSafe for safety.

  • Refactor HTTP agents in runner for global timeouts.


Diagram Walkthrough

flowchart LR
  A["Rust 0.x Majors"] --> B["Server Crates"]
  A --> C["Runner Crates"]
  B --> D["sqlx 0.9"]
  B --> E["argon2 0.6"]
  B --> F["reqwest 0.13"]
  C --> G["ureq 3"]
  C --> H["sha2 0.11"]
  D -. "AssertSqlSafe" .-> I["SQL Safety"]
  G -. "Global Timeout" .-> J["HTTP Reliability"]

File Walkthrough

Relevant files
Dependencies
4 files
Cargo.toml
Upgrade ureq from version 2 to version 3                                 
+1/-1     
Cargo.toml
Update windows-sys to version 0.61                                             
+1/-1     
Cargo.toml
Upgrade sha2, toml, and ureq to new versions                         
+3/-3     
Cargo.toml
Major version upgrades for multiple server crates               
+13/-13 
Configuration changes
1 files
renovate.json
Add rule to constrain libsqlite3-sys version                         
+11/-0   
Bug fix
18 files
ask.rs
Refactor error handling using new ureq response API           
+19/-18 
selfupdate.rs
Update body access methods for ureq v3 compatibility         
+3/-2     
setup.rs
Refactor pairing logic to handle non-2xx responses             
+18/-19 
ai.rs
Wrap SQL queries with AssertSqlSafe for safety                     
+7/-7     
games.rs
Apply AssertSqlSafe to game-related SQL queries                   
+10/-10 
mod.rs
Update SqliteArguments lifetime and add AssertSqlSafe       
+13/-13 
preview.rs
Add AssertSqlSafe to preview batch queries                             
+4/-4     
scan.rs
Wrap search rebuild SQL with AssertSqlSafe                             
+2/-2     
scenes.rs
Add AssertSqlSafe to scene cleanup queries                             
+1/-1     
auth.rs
Simplify password hashing by removing manual salt               
+6/-8     
facts.rs
Apply AssertSqlSafe to facts retrieval queries                     
+3/-3     
knowledge.rs
Wrap vector table creation with AssertSqlSafe                       
+1/-1     
projects.rs
Apply AssertSqlSafe to project update queries                       
+1/-1     
runs.rs
Add AssertSqlSafe to run and call filter queries                 
+2/-2     
search.rs
Wrap search query with AssertSqlSafe                                         
+3/-3     
tasks.rs
Apply AssertSqlSafe to task list and fetch queries             
+3/-3     
util.rs
Update rand import to use Rng instead of RngCore                 
+1/-1     
webpush.rs
Update elliptic curve point conversion method                       
+3/-3     
Enhancement
2 files
gpuapps.rs
Use shared agent helper for GPU app checks                             
+3/-3     
main.rs
Introduce global timeout agent helper function                     
+12/-7   
Tests
3 files
selfupdate_tests.rs
Update tests to use new agent helper function                       
+3/-3     
overview_tests.rs
Update test setup to use AssertSqlSafe                                     
+1/-1     
webpush_tests.rs
Update test assertion for new point conversion                     
+1/-1     
Documentation
1 files
forge.rs
Import KeyInit trait for HMAC signature handling                 
+1/-1     
Additional files
2 files
main.rs +3/-1     
trace_tests.rs +1/-1     

## Title <!-- pr-agent:describe:persistent --> deps: Rust 0.x majors in one port (sqlx 0.9, argon2 0.6, rand 0.10, RustCrypto, reqwest 0.13, ureq 3, …) ___ ### **PR Type** Bug fix, Enhancement, Documentation ___ ### **Description** - Port Rust crates to 0.x majors across server and runner. - Harden SQL queries with `sqlx::AssertSqlSafe` for safety. - Refactor HTTP agents in runner for global timeouts. ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Rust 0.x Majors"] --> B["Server Crates"] A --> C["Runner Crates"] B --> D["sqlx 0.9"] B --> E["argon2 0.6"] B --> F["reqwest 0.13"] C --> G["ureq 3"] C --> H["sha2 0.11"] D -. "AssertSqlSafe" .-> I["SQL Safety"] G -. "Global Timeout" .-> J["HTTP Reliability"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><details><summary>4 files</summary><table> <tr> <td><strong>Cargo.toml</strong><dd><code>Upgrade ureq from version 2 to version 3</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/desktop/src-tauri/Cargo.toml">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>Cargo.toml</strong><dd><code>Update windows-sys to version 0.61</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/machine-stats/Cargo.toml">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>Cargo.toml</strong><dd><code>Upgrade sha2, toml, and ureq to new versions</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/Cargo.toml">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>Cargo.toml</strong><dd><code>Major version upgrades for multiple server crates</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/Cargo.toml">+13/-13</a>&nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>renovate.json</strong><dd><code>Add rule to constrain libsqlite3-sys version</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/renovate.json">+11/-0</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Bug fix</strong></td><td><details><summary>18 files</summary><table> <tr> <td><strong>ask.rs</strong><dd><code>Refactor error handling using new ureq response API</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/src/ask.rs">+19/-18</a>&nbsp; </td> </tr> <tr> <td><strong>selfupdate.rs</strong><dd><code>Update body access methods for ureq v3 compatibility</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/src/selfupdate.rs">+3/-2</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>setup.rs</strong><dd><code>Refactor pairing logic to handle non-2xx responses</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/src/setup.rs">+18/-19</a>&nbsp; </td> </tr> <tr> <td><strong>ai.rs</strong><dd><code>Wrap SQL queries with AssertSqlSafe for safety</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/assets/ai.rs">+7/-7</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>games.rs</strong><dd><code>Apply AssertSqlSafe to game-related SQL queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/assets/games.rs">+10/-10</a>&nbsp; </td> </tr> <tr> <td><strong>mod.rs</strong><dd><code>Update SqliteArguments lifetime and add AssertSqlSafe</code>&nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/assets/mod.rs">+13/-13</a>&nbsp; </td> </tr> <tr> <td><strong>preview.rs</strong><dd><code>Add AssertSqlSafe to preview batch queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/assets/preview.rs">+4/-4</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>scan.rs</strong><dd><code>Wrap search rebuild SQL with AssertSqlSafe</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/assets/scan.rs">+2/-2</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>scenes.rs</strong><dd><code>Add AssertSqlSafe to scene cleanup queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/assets/scenes.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>auth.rs</strong><dd><code>Simplify password hashing by removing manual salt</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/auth.rs">+6/-8</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>facts.rs</strong><dd><code>Apply AssertSqlSafe to facts retrieval queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/facts.rs">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>knowledge.rs</strong><dd><code>Wrap vector table creation with AssertSqlSafe</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/knowledge.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>projects.rs</strong><dd><code>Apply AssertSqlSafe to project update queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/projects.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>runs.rs</strong><dd><code>Add AssertSqlSafe to run and call filter queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/runs.rs">+2/-2</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>search.rs</strong><dd><code>Wrap search query with AssertSqlSafe</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/search.rs">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>tasks.rs</strong><dd><code>Apply AssertSqlSafe to task list and fetch queries</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/tasks.rs">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>util.rs</strong><dd><code>Update rand import to use Rng instead of RngCore</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/util.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>webpush.rs</strong><dd><code>Update elliptic curve point conversion method</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/webpush.rs">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Enhancement</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>gpuapps.rs</strong><dd><code>Use shared agent helper for GPU app checks</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/src/gpuapps.rs">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>main.rs</strong><dd><code>Introduce global timeout agent helper function</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/src/main.rs">+12/-7</a>&nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>3 files</summary><table> <tr> <td><strong>selfupdate_tests.rs</strong><dd><code>Update tests to use new agent helper function</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/runner/src/selfupdate_tests.rs">+3/-3</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>overview_tests.rs</strong><dd><code>Update test setup to use AssertSqlSafe</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/overview_tests.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>webpush_tests.rs</strong><dd><code>Update test assertion for new point conversion</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/webpush_tests.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Documentation</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>forge.rs</strong><dd><code>Import KeyInit trait for HMAC signature handling</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/forge.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr><tr><td><strong>Additional files</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>main.rs</strong></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/desktop/src-tauri/src/main.rs">+3/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td><strong>trace_tests.rs</strong></td> <td><a href="https://git.kreative-kompas.com/khyretos/kreative-kompanion/src/branch/deps/rust-majors-2026-11-09/server/src/trace_tests.rs">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___
Collaborator

PR Reviewer Guide 🔍

(Review updated until commit 8633c28be8)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

ℹ️ Chunked review: the diff exceeded the model token budget, so it was reviewed in 6 chunks and the per-chunk results were merged.


📝 Summary: No code review findings were reported across the six parts of this pull request. Consequently, there are no defects to consolidate or risks to summarize based on the provided input.

✂️ Consider splitting this PR: it needed 6 review chunks. Suggested split points (one PR per module):

  • server/src/: 30 file(s), 230 changed line(s)
  • runner/src/: 6 file(s), 110 changed line(s)
  • server/: 1 file(s), 27 changed line(s)
  • (repository root)/: 1 file(s), 11 changed line(s)
  • desktop/src-tauri/: 2 file(s), 6 changed line(s)
  • runner/: 1 file(s), 6 changed line(s)
  • the other 1 module(s): 1 file(s)
## PR Reviewer Guide 🔍 <!-- pr-agent:review:full --> #### (Review updated until commit https://git.kreative-kompas.com/khyretos/kreative-kompanion/commit/8633c28be8b93e005fc191d12e8918f38929cf71) Here are some key observations to aid the review process: <table> <tr><td>🧪&nbsp;<strong>No relevant tests</strong></td></tr> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>No major issues detected</strong></td></tr> </table> <hr> ℹ️ **Chunked review:** the diff exceeded the model token budget, so it was reviewed in 6 chunks and the per-chunk results were merged. <hr> 📝 **Summary:** No code review findings were reported across the six parts of this pull request. Consequently, there are no defects to consolidate or risks to summarize based on the provided input. ✂️ **Consider splitting this PR:** it needed 6 review chunks. Suggested split points (one PR per module): - `server/src/`: 30 file(s), 230 changed line(s) - `runner/src/`: 6 file(s), 110 changed line(s) - `server/`: 1 file(s), 27 changed line(s) - `(repository root)/`: 1 file(s), 11 changed line(s) - `desktop/src-tauri/`: 2 file(s), 6 changed line(s) - `runner/`: 1 file(s), 6 changed line(s) - the other 1 module(s): 1 file(s)
server: install rustls's ring provider before building reqwest clients
Some checks failed
review-gate / sweep (pull_request) Has been cancelled
kreative-pr/review reviewed: 0 finding(s)
build / skills (pull_request) Successful in 15s
build / web (pull_request) Successful in 16s
build / server (pull_request) Failing after 2m38s
kk / all-checks Failed: build / server (pull_request)
build / runner (pull_request) Successful in 1m15s
build / runner-windows (pull_request) Successful in 31s
build / web-live (pull_request) Successful in 4m3s
fresh-install / fresh-install (pull_request) Successful in 3m13s
lint / megalinter (pull_request) Successful in 2m47s
desktop / linux (pull_request) Successful in 6m58s
aa559cd39d
reqwest 0.13 with rustls-no-provider panics when no crypto provider is
installed (clubuno's tests hit it). crate::http() installs ring once
(rustls with only the ring feature, which lettre already uses) and returns
the client builder; all reqwest clients go through it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

🧹 Lint report · ✅ all 25 checks clean

Errors below fail this check.

✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint

MegaLinter on soucouyant · full logs in the Actions run · comment /improve for AI fix suggestions

<!-- kk-lint --> ## 🧹 Lint report · ✅ all 25 checks clean Errors below fail this check. ✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint <sub>MegaLinter on soucouyant · full logs in the Actions run · comment <code>/improve</code> for AI fix suggestions</sub>
server: the last bare reqwest clients go through crate::http() too
Some checks failed
review-gate / sweep (pull_request) Has been cancelled
kreative-pr/review reviewed: 0 finding(s)
build / server (pull_request) Successful in 44s
build / skills (pull_request) Successful in 15s
build / web (pull_request) Successful in 9s
build / runner (pull_request) Successful in 22s
build / runner-windows (pull_request) Successful in 12s
build / web-live (pull_request) Successful in 3m46s
desktop / linux (pull_request) Successful in 3m10s
lint / megalinter (pull_request) Successful in 56s
fresh-install / fresh-install (pull_request) Successful in 7m24s
review-gate / gate review findings are all handled
kk / all-checks All 11 checks passed
8633c28be8
nextest runs every test in its own process, so a test that builds
Client::new() before anything installed the rustls provider panicked
(skillrepo::tests::test_forge_stub). skillrepo and the comfy tests now
use crate::http().

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
khyretos/kreative-kompanion!361
No description provided.