DROP-ANYWHERE: drop a file anywhere in the chat to attach it, with a drop square #309
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "khyretos/drop-anywhere"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
DROP-ANYWHERE: drag and drop of files into the chat was broken.
The drop handlers lived only on the composer box, so a file dropped on the messages (or anywhere else) was opened by the browser instead of attached.
typesincludesFiles): dragged text and task cards are untouched.<input type=file>still handles its own drops.dragoverand attaches; a text drag shows nothing. All 8 attach tests pass,tsc --noEmitis clean.Title
DROP-ANYWHERE: drop a file anywhere in the chat to attach it, with a drop square
User description
DROP-ANYWHERE: drag and drop of files into the chat was broken.
The drop handlers lived only on the composer box, so a file dropped on the messages (or anywhere else) was opened by the browser instead of attached.
typesincludesFiles): dragged text and task cards are untouched.<input type=file>still handles its own drops.dragoverand attaches; a text drag shows nothing. All 8 attach tests pass,tsc --noEmitis clean.PR Type
Enhancement
Description
Enables file attachment by dropping anywhere in the chat window.
Shows a dashed drop square with an upload icon on drag-over.
Prevents browser default behavior to open dropped files directly.
Adds tests for new drop-anywhere functionality and non-file drags.
Diagram Walkthrough
File Walkthrough
main.ts
Implement global drag-and-drop handlers for file attachmentweb/src/main.ts
icons.ts
Add upload icon SVG path for drop overlayweb/src/views/icons.ts
overlay.
attach.spec.ts
Add tests for drop-anywhere file attachment featureweb/tests/attach.spec.ts
any drop.
styles.css
Add CSS styles for global drop overlay componentweb/src/styles.css
box.
PR Reviewer Guide 🔍
(Review updated until commit
3811bd5ba5)Here are some key observations to aid the review process:
PR Code Suggestions ✨
No code suggestions found for the PR.
🧹 Lint report · ✅ all 25 checks clean
Errors below fail this check.
✅ Clean: black, checkstyle, djlint, editorconfig-checker, git_diff, gitleaks, grype, hadolint, htmlhint, isort, jsonlint, markdownlint, npm-groovy-lint, pmd, prettier, prettier, ruff, secretlint, shellcheck, shfmt, stylelint, trivy, trufflehog, xmllint, yamllint
MegaLinter on soucouyant · full logs in the Actions run · comment
/improvefor AI fix suggestions/review